From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxEFC-0002i3-Ll for qemu-devel@nongnu.org; Tue, 26 May 2015 08:46:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxEF5-0001vJ-Sf for qemu-devel@nongnu.org; Tue, 26 May 2015 08:46:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxEF5-0001vE-N3 for qemu-devel@nongnu.org; Tue, 26 May 2015 08:45:59 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 54EB26C for ; Tue, 26 May 2015 12:45:59 +0000 (UTC) Message-ID: <55646B02.8040601@redhat.com> Date: Tue, 26 May 2015 14:45:54 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430152117-100558-1-git-send-email-pbonzini@redhat.com> <1430152117-100558-28-git-send-email-pbonzini@redhat.com> <20150526124240.GZ13749@ad.nay.redhat.com> In-Reply-To: <20150526124240.GZ13749@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 27/29] memory: replace cpu_physical_memory_reset_dirty() with test-and-clear List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 26/05/2015 14:42, Fam Zheng wrote: >> > { >> > - cpu_physical_memory_clear_dirty_range_type(start, length, DIRTY_MEMORY_MIGRATION); >> > - cpu_physical_memory_clear_dirty_range_type(start, length, DIRTY_MEMORY_VGA); >> > - cpu_physical_memory_clear_dirty_range_type(start, length, DIRTY_MEMORY_CODE); >> > + cpu_physical_memory_test_and_clear_dirty(start, length, DIRTY_MEMORY_MIGRATION); > Is this line too long? Otherwise, Yes, it's 84 characters long. On the other hand, it is shorter than the existing line... Paolo > Reviewed-by: Fam Zheng > >> > + cpu_physical_memory_test_and_clear_dirty(start, length, DIRTY_MEMORY_VGA); >> > + cpu_physical_memory_test_and_clear_dirty(start, length, DIRTY_MEMORY_CODE); >> > } >> >