From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxELU-0002TT-Om for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxELT-0004cp-Qi for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxELT-0004ci-Hl for qemu-devel@nongnu.org; Tue, 26 May 2015 08:52:35 -0400 Message-ID: <55646C91.4080409@redhat.com> Date: Tue, 26 May 2015 06:52:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432538908-26298-1-git-send-email-mukawa@igel.co.jp> <1432538908-26298-5-git-send-email-mukawa@igel.co.jp> <55639E2E.9040604@redhat.com> <1432608391.2198.39.camel@igel.co.jp> <5563F695.2080706@igel.co.jp> In-Reply-To: <5563F695.2080706@igel.co.jp> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wW61TDPn2b4bbvWl6xKWel4ExWu3dr6QO" Subject: Re: [Qemu-devel] [RFC PATCH 4/4] vhost-user: Add new option to specify vhost-user backend supports List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tetsuya Mukawa Cc: jasowang@redhat.com, n.nikolaev@virtualopensystems.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wW61TDPn2b4bbvWl6xKWel4ExWu3dr6QO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/25/2015 10:29 PM, Tetsuya Mukawa wrote: >>>> { 'struct': 'NetdevTapOptions', >>>> @@ -2259,7 +2261,8 @@ >>>> '*vhostfd': 'str', >>>> '*vhostfds': 'str', >>>> '*vhostforce': 'bool', >>>> - '*queues': 'uint32'} } >>>> + '*queues': 'uint32', >>>> + '*backend_features':'uint64'} } >>> Ewww. Making users figure out what integers to pass is NOT user >>> friendly. Better would be an enum type, and make the parameter an >>> optional array of enum values. >> Thanks for your comments.=20 >> I guess below may be good example. Is this same as your suggestion? >> >> virtio-net-pci,netdev=3Dhostnet3,id=3Dnet3,gso=3Doff,guest_tso4=3Doff= ,guest_tso6=3Doff >> >> So I will improve 'backend-features' like below. >> >> backend-features=3Dgso=3Doff,guest_tso4=3Doff,guest_tso6=3Doff >> >> Also I will fix 'qapi-schema.json' to work like above. >=20 > I seems it's impossible to implement like above. > I may need to implement like below. >=20 > virtio-net-pci,netdev=3Dhostnet3,id=3Dnet3,backend_gso=3Don,backend_gue= st_tso4=3Don,backend_guest_tso6=3Don Or even: virtio-net-pci,netdev=3Dhostnet3,id=3Dnet3,backend.gso=3Don,backend.guest= _tso4=3Don,backend.guest_tso6=3Don Look at -device for how to set up nested structs using '.' for a nice hierarchy of options all belonging to a common substruct. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wW61TDPn2b4bbvWl6xKWel4ExWu3dr6QO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVZGyRAAoJEKeha0olJ0Nqrc0H/2yrzqGCchZIKp30c7pVNF+/ Q+0XYpoXEg34r82mqbreZnLzCkizeP9qry0U9FHxvCQlU1Fc+drlHTtxeDNR/glQ FfwAakp5krXzEdWfC7xAtHGlTG7jNyXw0Po1h42n/ulb63kvEPJymf8fOPFKjfOS tBVA2Jq+Dhh0/qQgFglo03zsjky6vXK1rlFBHWCXtpPHr6GA0eJ55VFki3xvI9bT yMl6XfJNbf1nnUZDw0rYRnocAqdY+7DWiR+DiyNNSWoVStY6jMhRcf7uQMhUQMnP M9037eFq6SzVrAxuWixm8VmB+47Y2yz6srL6dxEdrKYa9Yn1Oc35IpD5weIC40w= =ByUG -----END PGP SIGNATURE----- --wW61TDPn2b4bbvWl6xKWel4ExWu3dr6QO--