From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxETp-000744-3o for qemu-devel@nongnu.org; Tue, 26 May 2015 09:01:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxETl-0007mH-QM for qemu-devel@nongnu.org; Tue, 26 May 2015 09:01:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57969) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxETl-0007m5-Kk for qemu-devel@nongnu.org; Tue, 26 May 2015 09:01:09 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 3D76B8EB4A for ; Tue, 26 May 2015 13:01:09 +0000 (UTC) Message-ID: <55646E94.5050309@redhat.com> Date: Tue, 26 May 2015 07:01:08 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-8-git-send-email-armbru@redhat.com> <555FA834.2080506@redhat.com> <87a8wrelmq.fsf@blackfin.pond.sub.org> In-Reply-To: <87a8wrelmq.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0m1ScXIRF3kKsTBKSO18hi96Um8mbh5Ob" Subject: Re: [Qemu-devel] [PATCH 07/20] monitor: Use trad. command interface for HMP pcie_aer_inject_error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0m1ScXIRF3kKsTBKSO18hi96Um8mbh5Ob Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/26/2015 03:25 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> On 05/22/2015 05:36 AM, Markus Armbruster wrote: >>> All QMP commands use the "new" handler interface (mhandler.cmd_new). >>> Most HMP commands still use the traditional interface (mhandler.cmd),= >>> but a few use the "new" one. Complicates handle_user_command() for n= o >>> gain, so I'm converting these to the traditional interface. >>> >> >>> + >>> + devfn =3D (int)qdict_get_int(qdict, "devfn"); >> >> Code motion, so the problem is pre-existing, but this cast is unneeded= =2E >> Up to you if you want to clean it up now. >=20 > While I occasionally do fold cleanups into mechanical changes, e.g in > PATCH 15, I'm reluctant to fold them into code motion. I totally agree - mixing cleanups into code motion makes the motion harder to review. If it gets cleaned up, it should be as a separate patch, at which point it starts to be out of scope of the goal of this series, and better as a separate patch to qemu-trivial or to the PCI tree= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0m1ScXIRF3kKsTBKSO18hi96Um8mbh5Ob Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVZG6UAAoJEKeha0olJ0NqrLIH/1hER3nIRg9cMyWB7saApxwa hq5u0DHjkcdtDrw93dtYP4it2y53r/dalkwhrviD0Jv6dscoZ18iinLCUjKDM0l8 3prvi/z56DBOHwC04WPCwFLKtOLSVtxMBSCq3HfLXd18NJALGrgg4yvHpCwAY2At iw+YHiccEPfrcQuD5MvrQBOrhrXTC3ort5xWCWvsYMs5GrAKWKw+fCEWGV4PUEpL NfLlN5YXKO0qyC9itFngC2FhUO89TztBfndZ+ON73rziJXp/osRzAfR6LxuoIjXK 5Ryp1aMyhjzrg+37ae612DMOtSKn1m7/bKqOLaRKJX142hnxdGIknanTGaNdl/M= =QXMk -----END PGP SIGNATURE----- --0m1ScXIRF3kKsTBKSO18hi96Um8mbh5Ob--