From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45830)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YxFPf-0005nD-52
	for qemu-devel@nongnu.org; Tue, 26 May 2015 10:01:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YxFPa-0007fC-Up
	for qemu-devel@nongnu.org; Tue, 26 May 2015 10:00:58 -0400
Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:36259)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YxFPa-0007ey-Ip
	for qemu-devel@nongnu.org; Tue, 26 May 2015 10:00:54 -0400
Received: by wgbgq6 with SMTP id gq6so98184390wgb.3
	for <qemu-devel@nongnu.org>; Tue, 26 May 2015 07:00:53 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <55647C8D.2090006@redhat.com>
Date: Tue, 26 May 2015 16:00:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <55645794.3020202@redhat.com>
	<1432644847-7566-1-git-send-email-michael.i.doherty@intel.com>
In-Reply-To: <1432644847-7566-1-git-send-email-michael.i.doherty@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/2] arch_init: Drop target-x86_64.conf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ikey Doherty <michael.i.doherty@intel.com>, qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>

CCing maintainer.

Paolo

On 26/05/2015 14:54, Ikey Doherty wrote:
> The target-x86_64.conf sysconfig file has been empty and essentially ignored
> now for several years. This change removes the unused file to enable moving
> towards a stateless configuration.
> 
> Signed-off-by: Ikey Doherty <michael.i.doherty@intel.com>
> ---
>  Makefile                             | 7 +------
>  arch_init.c                          | 1 -
>  sysconfigs/target/target-x86_64.conf | 0
>  3 files changed, 1 insertion(+), 7 deletions(-)
>  delete mode 100644 sysconfigs/target/target-x86_64.conf
> 
> diff --git a/Makefile b/Makefile
> index d945804..2d52536 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -389,13 +389,8 @@ ifneq (,$(findstring qemu-ga,$(TOOLS)))
>  endif
>  endif
>  
> -install-confdir:
> -	$(INSTALL_DIR) "$(DESTDIR)$(qemu_confdir)"
>  
> -install-sysconfig: install-datadir install-confdir
> -	$(INSTALL_DATA) $(SRC_PATH)/sysconfigs/target/target-x86_64.conf "$(DESTDIR)$(qemu_confdir)"
> -
> -install: all $(if $(BUILD_DOCS),install-doc) install-sysconfig \
> +install: all $(if $(BUILD_DOCS),install-doc) \
>  install-datadir install-localstatedir
>  ifneq ($(TOOLS),)
>  	$(call install-prog,$(TOOLS),$(DESTDIR)$(bindir))
> diff --git a/arch_init.c b/arch_init.c
> index 23d3feb..b5d90a4 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -136,7 +136,6 @@ static struct defconfig_file {
>      bool userconfig;
>  } default_config_files[] = {
>      { CONFIG_QEMU_CONFDIR "/qemu.conf",                   true },
> -    { CONFIG_QEMU_CONFDIR "/target-" TARGET_NAME ".conf", true },
>      { NULL }, /* end of list */
>  };
>  
> diff --git a/sysconfigs/target/target-x86_64.conf b/sysconfigs/target/target-x86_64.conf
> deleted file mode 100644
> index e69de29..0000000
>