From: Max Reitz <mreitz@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 4/5] gtk: add opengl support, using egl
Date: Tue, 26 May 2015 16:06:58 +0200 [thread overview]
Message-ID: <55647E02.4000605@redhat.com> (raw)
In-Reply-To: <1432645002.24602.9.camel@nilsson.home.kraxel.org>
On 26.05.2015 14:56, Gerd Hoffmann wrote:
> On Di, 2015-05-26 at 08:35 +0200, Gerd Hoffmann wrote:
>> Hi,
>>
>>> only). That, or pass -Wno-deprecated-declarations for compiling
>>> ui/gtk.c, but that seems very ugly to me.
>> We can also try some #pragma warn dance, to limit the
>> -Wno-deprecated-declarations to a small code block.
>>
>> We have something simliar already for a bug in the gtk2 headers.
> i.e. like this:
I don't like it very much, but you're the maintainer, so if you deem it
acceptable, I won't object. :-)
Google says clang supports GCC pragmas, so it should be fine, because I
don't think qemu is supposed to work with any other compiler anyway...
Max
next prev parent reply other threads:[~2015-05-26 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:19 [Qemu-devel] [PATCH v2 0/5] gtk: add opengl support Gerd Hoffmann
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 1/5] ui: use libexpoxy Gerd Hoffmann
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 2/5] ui: shader.h protect against double inclusion Gerd Hoffmann
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 3/5] ui: add egl-helpers Gerd Hoffmann
2015-05-23 17:36 ` Max Reitz
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 4/5] gtk: add opengl support, using egl Gerd Hoffmann
2015-05-23 17:44 ` Max Reitz
2015-05-26 6:35 ` Gerd Hoffmann
2015-05-26 12:56 ` Gerd Hoffmann
2015-05-26 14:06 ` Max Reitz [this message]
2015-05-26 14:12 ` Gerd Hoffmann
2015-05-20 15:19 ` [Qemu-devel] [PATCH v2 5/5] gtk: Replace gdk_cursor_new() Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55647E02.4000605@redhat.com \
--to=mreitz@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).