From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YxH9C-0001Jp-ES
	for qemu-devel@nongnu.org; Tue, 26 May 2015 11:52:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YxH9B-0003XZ-EL
	for qemu-devel@nongnu.org; Tue, 26 May 2015 11:52:06 -0400
Message-ID: <55649697.5000100@redhat.com>
Date: Tue, 26 May 2015 17:51:51 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <cover.1431967209.git.berto@igalia.com>
	<11e5272e78e9c9485b47c41feedd6a30dbf0cb8e.1431967209.git.berto@igalia.com>
	<556493A0.5040004@redhat.com>
	<w51a8wrgwwj.fsf@maestria.local.igalia.com>
In-Reply-To: <w51a8wrgwwj.fsf@maestria.local.igalia.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer
 needed after qcow2_cache_empty()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org

On 26.05.2015 17:51, Alberto Garcia wrote:
> On Tue 26 May 2015 05:39:12 PM CEST, Max Reitz <mreitz@redhat.com> wrote:
>
>>> After having emptied the cache, the data in the cache tables is no
>>> longer useful, so we can tell the kernel that we are done with it. In
>>> Linux this frees the resources associated with it.
>> Looks good, but by applying the same logic, you could do the same call
>> in qcow2_cache_create(). So what about it? :-)
> But after qcow2_cache_create() the memory is still unused so this
> doesn't have any affect.

That was too easy. Right.

Reviewed-by: Max Reitz <mreitz@redhat.com>

>> Also note that bdrv_commit() is used only by the HMP commit operation,
>> not by QMP commit.
> Thanks, I should probably clarify that in the commit message.
>
> Berto