From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56805)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YxHR0-0008Fc-GB
	for qemu-devel@nongnu.org; Tue, 26 May 2015 12:10:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YxHQu-00037N-RS
	for qemu-devel@nongnu.org; Tue, 26 May 2015 12:10:30 -0400
Message-ID: <55649AE3.3070404@redhat.com>
Date: Tue, 26 May 2015 18:10:11 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <cover.1431967209.git.berto@igalia.com>
	<74e0e0ce58935bf1c285bf484e8f3beb0e3c8f66.1431967209.git.berto@igalia.com>
In-Reply-To: <74e0e0ce58935bf1c285bf484e8f3beb0e3c8f66.1431967209.git.berto@igalia.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] qcow2: reorder fields in
 Qcow2CachedTable to reduce padding
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org

On 18.05.2015 18:48, Alberto Garcia wrote:
> Changing the current ordering saves 8 bytes per cache entry in x86_64.

Hm, not seven?

> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   block/qcow2-cache.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c
> index a215f5b..43590ff 100644
> --- a/block/qcow2-cache.c
> +++ b/block/qcow2-cache.c
> @@ -31,9 +31,9 @@
>   
>   typedef struct Qcow2CachedTable {
>       int64_t  offset;
> -    bool     dirty;
>       uint64_t lru_counter;
>       int      ref;
> +    bool     dirty;
>   } Qcow2CachedTable;
>   
>   struct Qcow2Cache {

With "7" above, or an explanation why it actually is 8:

Reviewed-by: Max Reitz <mreitz@redhat.com>