From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33514)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxHjS-00049l-JO
	for qemu-devel@nongnu.org; Tue, 26 May 2015 12:29:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxHjN-0001pY-Il
	for qemu-devel@nongnu.org; Tue, 26 May 2015 12:29:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55518)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxHjN-0001pU-E5
	for qemu-devel@nongnu.org; Tue, 26 May 2015 12:29:29 -0400
Message-ID: <55649F65.60807@redhat.com>
Date: Tue, 26 May 2015 18:29:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <55645794.3020202@redhat.com>
	<1432644847-7566-1-git-send-email-michael.i.doherty@intel.com>
	<55647C8D.2090006@redhat.com>
	<20150526162512.GS17796@thinpad.lan.raisama.net>
In-Reply-To: <20150526162512.GS17796@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/2] arch_init: Drop target-x86_64.conf
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Ikey Doherty <michael.i.doherty@intel.com>, qemu-devel@nongnu.org



On 26/05/2015 18:25, Eduardo Habkost wrote:
> Can you separate this into two patches? First deleting the empty
> target-x86_64.conf file from the tree & Makefile, then another patch
> deleting the
>   { CONFIG_QEMU_CONFDIR "/target-" TARGET_NAME ".conf", true }
> line in arch_init.c?
> 
> We can delete sysconfigs/target/target-x86_64.conf from our source tree
> immediately, but I am not sure we should disable loading of
> /etc/qemu/target-*.conf with no warning (users may have their own
> target-*.conf files in their systems).

What is the usecase?  Was /etc/qemu/target-*.conf actually meant to be
user-customizable when it hosted the CPU models?

Paolo

> We should probably warn about it in the 2.4 release announcement, and
> remove the arch_init.c line in 2.5.
> 
> I would even go further and argue for removing /etc/qemu config file
> auto-loading entirely in QEMU 2.5 (including qemu.conf and
> target-*.conf).