From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
Peter Crosthwaite <crosthwaitepeter@gmail.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] memory_mapping: Use qemu_common.h include
Date: Tue, 26 May 2015 19:18:51 +0200 [thread overview]
Message-ID: <5564AAFB.2040604@redhat.com> (raw)
In-Reply-To: <CAEgOgz6MwXzMG7u_WdMLDDYy1A27eqLTiLvZtKyYXOQSnf2HjQ@mail.gmail.com>
On 26/05/2015 19:05, Peter Crosthwaite wrote:
> OK, but it is an odd one out, would you be willing to accept
> the double include that seems to be widespread?
>
> +#include "qemu_common.h"
> #include "cpu.h"
> -#include "exec/cpu-all.h"
This is exactly what I meant. What is odd about it?
In fact, including exec/cpu-all.h outside cpu.h is definitely odd.
Paolo
next prev parent reply other threads:[~2015-05-26 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 6:38 [Qemu-devel] [PATCH] memory_mapping: Use qemu_common.h include Peter Crosthwaite
2015-05-26 8:12 ` Paolo Bonzini
2015-05-26 17:05 ` Peter Crosthwaite
2015-05-26 17:18 ` Paolo Bonzini [this message]
2015-05-26 17:31 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5564AAFB.2040604@redhat.com \
--to=pbonzini@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).