From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxJXr-0001Ss-7H for qemu-devel@nongnu.org; Tue, 26 May 2015 14:25:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxJXm-000691-Nj for qemu-devel@nongnu.org; Tue, 26 May 2015 14:25:42 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:37100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxJXl-00067W-C5 for qemu-devel@nongnu.org; Tue, 26 May 2015 14:25:37 -0400 Received: by wifw1 with SMTP id w1so41115326wif.0 for ; Tue, 26 May 2015 11:25:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5564BA91.60708@redhat.com> Date: Tue, 26 May 2015 20:25:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432322539-23719-1-git-send-email-thuth@redhat.com> <20150526125235.GJ13262@stefanha-thinkpad.redhat.com> <20150526150714.24b2cf8f@thh440s> In-Reply-To: <20150526150714.24b2cf8f@thh440s> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] net: Enable vlans and dump for -netdev, too, List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Jason Wang , Markus Armbruster , "Michael S. Tsirkin" On 26/05/2015 15:07, Thomas Huth wrote: > Certainly no objections from my side to keep this "vlan" concept in > QEMU, but thinking about this option again, I'd rather call it "hub=xx" > for the -netdev option instead of "vlan=xx", since this better matches > the "-netdev hubport" naming and it IMHO also describes the > functionality in a better way. > (of course I also need to add proper updates to the documentation files > in my patch in that way) I agree. It makes sense, because vlans have other uses besides dump (e.g. connecting VMs via the socket or l2tpv3 backends, where VMs have multiple NICs). Paolo