From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxMdo-0001Po-6R for qemu-devel@nongnu.org; Tue, 26 May 2015 17:44:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxMdk-0000Xl-Eo for qemu-devel@nongnu.org; Tue, 26 May 2015 17:44:03 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58659 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxMdk-0000Wq-88 for qemu-devel@nongnu.org; Tue, 26 May 2015 17:44:00 -0400 Message-ID: <5564E91D.1050504@suse.de> Date: Tue, 26 May 2015 23:43:57 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1432631384-470-1-git-send-email-aurelien@aurel32.net> <55649C14.1050207@twiddle.net> In-Reply-To: <55649C14.1050207@twiddle.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] target-s390x: fix LOAD MULTIPLE instruction on page boundary List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , Aurelien Jarno , qemu-devel@nongnu.org On 26.05.15 18:15, Richard Henderson wrote: > On 05/26/2015 02:09 AM, Aurelien Jarno wrote: >> This is an important detail in case the base register is in the list >> of registers to be loaded. If a page fault occurs this register might be >> overwritten and when the instruction is later restarted the wrong >> base register value is useD. >> >> Fix this by first loading the first and last value from memory, hence >> triggering all possible page faults, and then the remaining registers. >> >> This fixes random segmentation faults seen in the guest. >> >> Cc: Alexander Graf >> Cc: Richard Henderson >> Signed-off-by: Aurelien Jarno >> --- >> target-s390x/translate.c | 128 ++++++++++++++++++++++++++++++++++++----------- >> 1 file changed, 99 insertions(+), 29 deletions(-) >> >> Changes v1->v2: >> - Do the load in two steps: first and last registers, and then the remaining ones > > Reviewed-by: Richard Henderson Thanks, applied to s390-next. So what do we do about the other patch set? Alex