qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Warner Losh <imp@bsdimp.com>, qemu-devel@nongnu.org
Cc: Kyle Evans <kevans@freebsd.org>, Stacey Son <sson@FreeBSD.org>,
	Michal Meloun <mmel@FreeBSD.org>
Subject: Re: [PATCH v2 04/11] bsd-user: Implement freebsd11_mknod, freebsd11_mknodat and mknodat
Date: Sun, 26 Jun 2022 09:19:04 +0530	[thread overview]
Message-ID: <5564cd28-9b32-8ec3-0ec2-4cd218577b76@linaro.org> (raw)
In-Reply-To: <20220624214742.89229-5-imp@bsdimp.com>

On 6/24/22 14:47, Warner Losh wrote:
> These implement both the old-pre INO64 mknod variations, as well as the
> now current INO64 variant. To implement the old stuff, we use some
> linker magic to bind to the old versions of these functions.
> 
> Signed-off-by: Stacey Son<sson@FreeBSD.org>
> Signed-off-by: Michal Meloun<mmel@FreeBSD.org>
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
>   bsd-user/bsd-file.h           | 47 +++++++++++++++++++++++++++++++++++
>   bsd-user/freebsd/os-syscall.c | 13 ++++++++++
>   2 files changed, 60 insertions(+)

Update the comment -- no more linker magic.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2022-06-26  3:50 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24 21:47 [PATCH v2 00/11] bsd-user: More file-related system calls Warner Losh
2022-06-24 21:47 ` [PATCH v2 01/11] bsd-user: Implement mount, umount and nmount Warner Losh
2022-06-24 21:47 ` [PATCH v2 02/11] bsd-user: Implement symlink, symlinkat, readlink and readlinkat Warner Losh
2022-06-26  3:47   ` Richard Henderson
2022-06-24 21:47 ` [PATCH v2 03/11] bsd-user: implement chmod, fchmod, lchmod and fchmodat Warner Losh
2022-06-24 21:47 ` [PATCH v2 04/11] bsd-user: Implement freebsd11_mknod, freebsd11_mknodat and mknodat Warner Losh
2022-06-26  3:49   ` Richard Henderson [this message]
2022-06-24 21:47 ` [PATCH v2 05/11] bsd-user: Implement chown, fchown, lchown and fchownat Warner Losh
2022-06-24 21:47 ` [PATCH v2 06/11] bsd-user: Implement chflags, lchflags and fchflags Warner Losh
2022-06-24 21:47 ` [PATCH v2 07/11] bsd-user: Implement chroot and flock Warner Losh
2022-06-24 21:47 ` [PATCH v2 08/11] bsd-user: Implement mkfifo and mkfifoat Warner Losh
2022-06-24 21:47 ` [PATCH v2 09/11] bsd-user: Implement pathconf, lpathconf and fpathconf Warner Losh
2022-06-24 21:47 ` [PATCH v2 10/11] bsd-user: Implement undelete Warner Losh
2022-06-24 21:47 ` [PATCH v2 11/11] bsd-user: Remove stray 'inline' from do_bsd_close Warner Losh
2022-06-26  3:49   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5564cd28-9b32-8ec3-0ec2-4cd218577b76@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=mmel@FreeBSD.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sson@FreeBSD.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).