From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxStt-0004qq-Ud for qemu-devel@nongnu.org; Wed, 27 May 2015 00:25:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxStq-00074H-Oe for qemu-devel@nongnu.org; Wed, 27 May 2015 00:25:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42777) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxStq-00072N-JS for qemu-devel@nongnu.org; Wed, 27 May 2015 00:25:02 -0400 Message-ID: <5565471C.9080505@redhat.com> Date: Tue, 26 May 2015 22:25:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431327525-25625-1-git-send-email-justin@quarantainenet.nl> <1431327525-25625-3-git-send-email-justin@quarantainenet.nl> In-Reply-To: <1431327525-25625-3-git-send-email-justin@quarantainenet.nl> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1a8ux8Au7XVw8HbwkuGKrdG1MqVqnVmuO" Subject: Re: [Qemu-devel] [PATCH v4 2/2] qga/qmp_guest_fstrim: Return per path fstrim result List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Justin Ossevoort , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1a8ux8Au7XVw8HbwkuGKrdG1MqVqnVmuO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/11/2015 12:58 AM, Justin Ossevoort wrote: > The current guest-fstrim support only returns an error if some > mountpoint was unable to be trimmed, skipping any possible additional > mountpoints. The result of the TRIM operation itself is also discarded.= >=20 > This change returns a per mountpoint result of the TRIM operation. If a= n > error occurs on some mountpoints that error is returned and the > guest-fstrim continue with any additional mountpoints. >=20 > The returned values for errors, minimum and trimmed are dependant on th= e > filesystem, storage stacks and kernel version. >=20 > Signed-off-by: Justin Ossevoort > --- > qga/commands-posix.c | 54 ++++++++++++++++++++++++++++++++++++++------= -------- > qga/commands-win32.c | 4 +++- > qga/qapi-schema.json | 32 ++++++++++++++++++++++++++++--- > 3 files changed, 72 insertions(+), 18 deletions(-) >=20 > @@ -437,12 +461,14 @@ > # fragmented free space, although not all blocks will be discard= ed. > # The default value is zero, meaning "discard every free block".= > # > -# Returns: Nothing. > +# Returns: A @GuestFilesystemTrimResponse which contains the > +# status of all trimmed paths. Maybe mention (since 2.4) as part of the Returns: line. > # > -# Since: 1.2 > +# Since: 2.4 NACK to this hunk. The command itself has existed since 1.2, it is only the returns type that has changed in 2.4. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1a8ux8Au7XVw8HbwkuGKrdG1MqVqnVmuO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVZUccAAoJEKeha0olJ0NqHeUH/1WfJTinmuYaQTutH+Vt/shQ +sf9yN0aFREtfbycLklFXU+kptBQ+yczxkQ9EhgItxOMMKpetYC764JvBbTaGz7Q lnElyP9Ppo1236PLhCjQeNuVItGg5hMU+owBzipY1rIHCDV8tEEwS0sCSqa4EEbT dI0VgEhKxTkw4xLxfmtuh1YxOVG1zE/dw+G4Ul2cvcIpUPwXE/+RRZE4S2VWRzCg VGU6zC9CEf9xwKVVYN0+avbvhk4GOCrr2IjIc/Eg9WYDldzZSZoIT7qc69wXGhjH 2e3uFPvCU7RZ6Wu4Db1adgFyTSAy6Lumk7HkJo5K7WmddbqKVTXESpCfUXObU6E= =S3aF -----END PGP SIGNATURE----- --1a8ux8Au7XVw8HbwkuGKrdG1MqVqnVmuO--