From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxa7y-0001KQ-VX for qemu-devel@nongnu.org; Wed, 27 May 2015 08:08:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxa7u-0005wp-TH for qemu-devel@nongnu.org; Wed, 27 May 2015 08:08:06 -0400 Message-ID: <5565B398.3050602@redhat.com> Date: Wed, 27 May 2015 06:07:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432711146-28405-1-git-send-email-famz@redhat.com> <1432711146-28405-2-git-send-email-famz@redhat.com> In-Reply-To: <1432711146-28405-2-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nIDfMweChIG8vUMI3LMsSHqmC5BV5b6jN" Subject: Re: [Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_notifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , Stefan Weil , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nIDfMweChIG8vUMI3LMsSHqmC5BV5b6jN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/27/2015 01:19 AM, Fam Zheng wrote: > This function will register the fd handler similar to > aio_set_event_notifier, but the difference is the fd will only be polle= d > in the outmost aio_poll. s/outmost/outermost/ that will have a ripple effect throughout the patch series... >=20 > This is useful in some cases like device ioeventfd, where the handler > typically processes a guest request, therefore nested aio_poll shouldn'= t > include this. >=20 > Signed-off-by: Fam Zheng > --- > aio-posix.c | 33 +++++++++++++++++++++++++++------ > include/block/aio.h | 23 ++++++++++++++++++++--- > 2 files changed, 47 insertions(+), 9 deletions(-) >=20 > diff --git a/aio-posix.c b/aio-posix.c > index 4abec38..05a0502 100644 > --- a/aio-posix.c > +++ b/aio-posix.c > @@ -24,6 +24,7 @@ struct AioHandler > IOHandler *io_read; > IOHandler *io_write; > int deleted; > + bool outmost; =2E..like here But I'll probably let others do the technical review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nIDfMweChIG8vUMI3LMsSHqmC5BV5b6jN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVZbOYAAoJEKeha0olJ0NqDNAIAKG4nSw0h6oKVxcaepMf9MDo XQHtSKFv5BDlfYHTN3hYT9KPofHSEGs2ZleLH4XvUM9rgu9dHhRRlVINVSN9e0+Y n2N6Q0tjQ64sKn+PwapicFBXu39bd+Wv08SKoE7QTTyAJDS7XwAESuDMLRALhHlt uwU5OkUfJI2cHWcIUsZMXPQ9qqz5KANOoV+0C5xJqUqxL38CachUSn6GmgkCzUPX PD8koT80TeCvlycl/3zJ2kb5nCuqaH69FHXzXPWQ5gdCW0iLqd31L2TEtfacsian RSBiGhRS/qwzDhFxJhP2bQZCLG97CoSnEVsVzyX6PHakx+jg2+s9Xw7TK6AA4Xo= =7aSy -----END PGP SIGNATURE----- --nIDfMweChIG8vUMI3LMsSHqmC5BV5b6jN--