qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] watchdog: convert to QemuOpts
Date: Wed, 27 May 2015 14:45:29 +0200	[thread overview]
Message-ID: <5565BC69.7020402@redhat.com> (raw)
In-Reply-To: <20150527124144.GM29283@redhat.com>



On 27/05/2015 14:41, Richard W.M. Jones wrote:
>> > -                if (watchdog) {
>> > -                    fprintf(stderr,
>> > -                            "qemu: only one watchdog option may be given\n");
>> > -                    return 1;
>> > +                olist = qemu_find_opts("watchdog");
>> > +                opts = qemu_opts_parse(olist, optarg, 1);
>> > +                if (!opts) {
>> > +                    exit(1);
>> >                  }
> Is there an error message missing (before the call to exit)?

Oh, I forgot to answer this.  Any error message is printed by
qemu_opts_parse, for example:

$ x86_64-softmmu/qemu-system-x86_64 -watchdog foo=bar
qemu-system-x86_64: -watchdog foo=bar: Invalid parameter 'foo'

Paolo

  parent reply	other threads:[~2015-05-27 12:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 12:35 [Qemu-devel] [PATCH] watchdog: convert to QemuOpts Paolo Bonzini
2015-05-27 12:41 ` Richard W.M. Jones
2015-05-27 12:44   ` Paolo Bonzini
2015-05-27 12:45   ` Paolo Bonzini [this message]
2015-05-27 12:48     ` Richard W.M. Jones
2015-05-27 13:00 ` Eric Blake
2015-05-27 13:02   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5565BC69.7020402@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).