qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction
Date: Wed, 27 May 2015 07:31:01 -0700	[thread overview]
Message-ID: <5565D525.1010608@twiddle.net> (raw)
In-Reply-To: <20150526220329.GB12677@aurel32.net>

On 05/26/2015 03:03 PM, Aurelien Jarno wrote:
> Ok, I understand now. That said I don't see how implementing STFLE will
> break that. I think it will actually improve things by enabling more
> facilities and thus making the kernel happier (but maybe not enough).

Somewhat amusingly, by not implementing STFLE we bypass this check.


>> #elif defined(CONFIG_MARCH_Z990)
>>         .long 1, 0xc0002000
> 
> For this one we only miss one instruction in the LD facility. I have it
> on my TODO list, though it might take a few weeks until it goes to the
> top.
> 

Which one?

>> #elif defined(CONFIG_MARCH_Z900)
>>         .long 1, 0xc0000000
> 
> This corresponds to the current value we provide. CONFIG_MARCH_Z900 also
> correspond to the configuration of the Debian kernel, that's why I am
> able to boot kernels.

Ah, well that's something.  Fedora defaults to z9-109, and I think SuSE does
the same.


r~

  reply	other threads:[~2015-05-27 14:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-24 23:47 [Qemu-devel] [PATCH 00/10] target-s390x: TCG fixes and improvements Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 01/10] target-s390x: fix PSW value on dynamical exception from helpers Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 02/10] target-s390x: fix MMU index computation Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 03/10] target-s390x: define default NaN values Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 04/10] target-s390x: silence NaNs for LOAD LENGTHENED and LOAD ROUNDED Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 05/10] target-s390x: detect tininess before rounding for FP operations Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 06/10] target-s390x: improve facilities list Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 07/10] target-s390x: enable fully implemented facilities Aurelien Jarno
2015-05-25 20:39   ` Alexander Graf
2015-05-25 21:02     ` Aurelien Jarno
2015-05-25 21:04       ` Alexander Graf
2015-05-25 21:13         ` Aurelien Jarno
2015-05-25 21:47           ` Alexander Graf
2015-05-26  6:02             ` Aurelien Jarno
2015-05-26  8:29               ` Alexander Graf
2015-05-26  9:05                 ` Aurelien Jarno
2015-05-26 10:19                   ` Alexander Graf
2015-05-24 23:47 ` [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE instruction Aurelien Jarno
2015-05-25 23:08   ` Richard Henderson
2015-05-25 23:14     ` Alexander Graf
2015-05-26  6:03     ` Aurelien Jarno
2015-05-26 16:00       ` Richard Henderson
2015-05-26 22:03         ` Aurelien Jarno
2015-05-27 14:31           ` Richard Henderson [this message]
2015-05-27 14:55             ` Alexander Graf
2015-05-27 15:57             ` Aurelien Jarno
2015-05-28  1:55               ` Alexander Graf
2015-05-24 23:47 ` [Qemu-devel] [PATCH 09/10] target-s390x: move a few instructions to the correct facility Aurelien Jarno
2015-05-24 23:47 ` [Qemu-devel] [PATCH 10/10] target-s390x: implement LAY and LAEY instructions Aurelien Jarno
2015-05-28 22:03 ` [Qemu-devel] [PATCH 00/10] target-s390x: TCG fixes and improvements Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5565D525.1010608@twiddle.net \
    --to=rth@twiddle.net \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).