From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46872)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YxcMU-0001fc-H6
	for qemu-devel@nongnu.org; Wed, 27 May 2015 10:31:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YxcMO-0004eD-Ib
	for qemu-devel@nongnu.org; Wed, 27 May 2015 10:31:14 -0400
Received: from mail-qc0-x232.google.com ([2607:f8b0:400d:c01::232]:34580)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YxcMO-0004dY-F7
	for qemu-devel@nongnu.org; Wed, 27 May 2015 10:31:08 -0400
Received: by qcbhb1 with SMTP id hb1so4526571qcb.1
	for <qemu-devel@nongnu.org>; Wed, 27 May 2015 07:31:07 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5565D525.1010608@twiddle.net>
Date: Wed, 27 May 2015 07:31:01 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1432511251-22515-1-git-send-email-aurelien@aurel32.net>
	<1432511251-22515-9-git-send-email-aurelien@aurel32.net>
	<5563AB72.3070601@twiddle.net> <20150526060313.GC29207@aurel32.net>
	<556498A2.3050601@twiddle.net> <20150526220329.GB12677@aurel32.net>
In-Reply-To: <20150526220329.GB12677@aurel32.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/10] target-s390x: implement STFLE
	instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On 05/26/2015 03:03 PM, Aurelien Jarno wrote:
> Ok, I understand now. That said I don't see how implementing STFLE will
> break that. I think it will actually improve things by enabling more
> facilities and thus making the kernel happier (but maybe not enough).

Somewhat amusingly, by not implementing STFLE we bypass this check.


>> #elif defined(CONFIG_MARCH_Z990)
>>         .long 1, 0xc0002000
> 
> For this one we only miss one instruction in the LD facility. I have it
> on my TODO list, though it might take a few weeks until it goes to the
> top.
> 

Which one?

>> #elif defined(CONFIG_MARCH_Z900)
>>         .long 1, 0xc0000000
> 
> This corresponds to the current value we provide. CONFIG_MARCH_Z900 also
> correspond to the configuration of the Debian kernel, that's why I am
> able to boot kernels.

Ah, well that's something.  Fedora defaults to z9-109, and I think SuSE does
the same.


r~