From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51881)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1Yxm67-0003Dr-Si
	for qemu-devel@nongnu.org; Wed, 27 May 2015 20:55:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1Yxm66-0005RK-TB
	for qemu-devel@nongnu.org; Wed, 27 May 2015 20:54:59 -0400
Message-ID: <55666856.9020202@cn.fujitsu.com>
Date: Thu, 28 May 2015 08:59:02 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <1431105726-3682-1-git-send-email-kwolf@redhat.com>
	<1431105726-3682-12-git-send-email-kwolf@redhat.com>
	<555D7183.8080203@cn.fujitsu.com>
	<20150527123118.GE4669@noname.str.redhat.com>
In-Reply-To: <20150527123118.GE4669@noname.str.redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/34] block: Allow references for backing
 files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: jcody@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com

On 05/27/2015 08:31 PM, Kevin Wolf wrote:
> Am 21.05.2015 um 07:47 hat Wen Congyang geschrieben:
>> On 05/09/2015 01:21 AM, Kevin Wolf wrote:
>>> For bs->file, using references to existing BDSes has been possible for a
>>> while already. This patch enables the same for bs->backing_hd.
>>
>> 1. We reference to an existing BDSes, and some disk uses this blk. Do
>> we allow this?
> 
> Currently yes. If it breaks, you get to keep both pieces.
> 
> As long as your guest device is read-only, it should just work. It would
> be a very bad idea, though, to write to a backing file.
> 
> Op blockers should eventually prevent this from happening (Jeff, you may
> want to take a note ;-))
> 
>> 2. bs->backing_hd->blk can be not NULL now? If we do an active commit
>> to this backing file(use mirror job), we will call bdrv_swap() in
>> mirror_exit(), and the function bdrv_swap() doesn't allow that
>> new_bs->blk(here is bs->backing_hd) is not NULL.
> 
> You're right.
> 
> I can remove this patch from the series for now, but of course that
> doesn't solve the problem. I'm not sure what to do about it. Making
> bdrv_swap() work with BDSes that have BB attached is probably another
> item in the list of "dynamic reconfiguration" problems.

What does "dynamic reconfiguration" mean? Allow to change drive's option
when guest is running?

Thanks
Wen Congyang

> 
> Markus, any ideas?
> 
> Kevin
> .
>