From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxocj-00032W-Uz for qemu-devel@nongnu.org; Wed, 27 May 2015 23:36:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxocf-0000lN-18 for qemu-devel@nongnu.org; Wed, 27 May 2015 23:36:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxoce-0000kY-Q1 for qemu-devel@nongnu.org; Wed, 27 May 2015 23:36:44 -0400 Message-ID: <55668D46.9090204@redhat.com> Date: Thu, 28 May 2015 11:36:38 +0800 From: Jason Wang MIME-Version: 1.0 References: <1425880835-13230-1-git-send-email-pagupta@redhat.com> <314829841.4949261.1432708003823.JavaMail.zimbra@redhat.com> <5565842E.9020901@redhat.com> <20150527135639-mutt-send-email-mst@redhat.com> <5566899C.2030708@redhat.com> In-Reply-To: <5566899C.2030708@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Michal Privoznik , Pankaj Gupta , qemu-devel@nongnu.org, aliguori@amazon.com On 05/28/2015 11:21 AM, Jason Wang wrote: > > On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: >> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: >>>> >>>> On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >>>>>> Ping. >>>>>> >>>>>> Can I get any suggestions on this patch. >>>>>> >>>>>> Best regards, >>>>>> Pankaj >>>>>> >>>>>>>> vhostforce was added to enable vhost when >>>>>>>> guest don't have MSI-X support. >>>>>>>> Now, we have scenarios like DPDK in Guest which dont use >>>>>>>> interrupts and still use vhost. Also, performance of guests >>>>>>>> without MSI-X support is getting less popular. >>>>>>>> >>>>>>>> Its OK to remove this extra option and enable vhost >>>>>>>> on the basis of vhost=ON/OFF. >>>>>>>> Done basic testing with vhost on/off for latest guests >>>>>>>> and old guests(non-msix). >>>>>>>> >>>>>>>> Signed-off-by: Pankaj Gupta >>>> Looks good. Two questions: >>>> >>>> - Did libvirt use this? if not, we may want to drop vhostfore option >>>> completely. >> Yes, it did. >> > For vhost-user, vhostforce is mandatory. But how about tap? Looks like > it was not used, and I could not even find any option in > http://libvirt.org/formatdomain.html. > CC Michal for the answer.