From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
jsnow@redhat.com, wangxiaolong@ucloud.cn
Subject: Re: [Qemu-devel] [PATCH v6 1/8] block: Add bdrv_get_block_status_above
Date: Thu, 28 May 2015 10:27:22 +0200 [thread overview]
Message-ID: <5566D16A.6010203@redhat.com> (raw)
In-Reply-To: <1432790990-25383-2-git-send-email-famz@redhat.com>
On 28/05/2015 07:29, Fam Zheng wrote:
> Like bdrv_is_allocated_above, this function follows the backing chain until seeing
> BDRV_BLOCK_ALLOCATED. Base is not included.
>
> Reimplement bdrv_is_allocated on top.
"Reimplement bdrv_get_block_status on top".
Can be fixed by whoever commits this, so
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2015-05-28 8:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 5:29 [Qemu-devel] [PATCH v6 0/8] block: Mirror discarded sectors Fam Zheng
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 1/8] block: Add bdrv_get_block_status_above Fam Zheng
2015-05-28 8:27 ` Paolo Bonzini [this message]
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 2/8] qmp: Add optional bool "unmap" to drive-mirror Fam Zheng
2015-05-28 8:28 ` Paolo Bonzini
2015-06-02 17:28 ` Eric Blake
2015-06-03 7:13 ` Fam Zheng
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 3/8] mirror: Do zero write on target if sectors not allocated Fam Zheng
2015-05-28 8:28 ` Paolo Bonzini
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 4/8] block: Fix dirty bitmap in bdrv_co_discard Fam Zheng
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 5/8] block: Remove bdrv_reset_dirty Fam Zheng
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 6/8] qemu-iotests: Make block job methods common Fam Zheng
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 7/8] qemu-iotests: Add test case for mirror with unmap Fam Zheng
2015-05-28 8:29 ` Paolo Bonzini
2015-05-28 5:29 ` [Qemu-devel] [PATCH v6 8/8] iotests: Use event_wait in wait_ready Fam Zheng
2015-05-28 8:30 ` Paolo Bonzini
2015-06-02 16:02 ` [Qemu-devel] [Qemu-block] [PATCH v6 0/8] block: Mirror discarded sectors Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566D16A.6010203@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangxiaolong@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).