From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56457)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxtA9-000714-6t
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:27:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YxtA8-0005k6-Go
	for qemu-devel@nongnu.org; Thu, 28 May 2015 04:27:37 -0400
Message-ID: <5566D16A.6010203@redhat.com>
Date: Thu, 28 May 2015 10:27:22 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1432790990-25383-1-git-send-email-famz@redhat.com>
	<1432790990-25383-2-git-send-email-famz@redhat.com>
In-Reply-To: <1432790990-25383-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 1/8] block: Add
	bdrv_get_block_status_above
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>, qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, jsnow@redhat.com, wangxiaolong@ucloud.cn



On 28/05/2015 07:29, Fam Zheng wrote:
> Like bdrv_is_allocated_above, this function follows the backing chain until seeing
> BDRV_BLOCK_ALLOCATED.  Base is not included.
> 
> Reimplement bdrv_is_allocated on top.

"Reimplement bdrv_get_block_status on top".

Can be fixed by whoever commits this, so

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

> Signed-off-by: Fam Zheng <famz@redhat.com>