From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxtOH-0007H9-IH for qemu-devel@nongnu.org; Thu, 28 May 2015 04:42:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxtOE-0002Gn-8W for qemu-devel@nongnu.org; Thu, 28 May 2015 04:42:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxtOE-0002Gj-2R for qemu-devel@nongnu.org; Thu, 28 May 2015 04:42:10 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 9BC6BB6E63 for ; Thu, 28 May 2015 08:42:09 +0000 (UTC) Message-ID: <5566D4DD.8030507@redhat.com> Date: Thu, 28 May 2015 10:42:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432760765-28492-1-git-send-email-lersek@redhat.com> <87pp5lgko0.fsf@blackfin.pond.sub.org> In-Reply-To: <87pp5lgko0.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Laszlo Ersek Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 28/05/2015 10:39, Markus Armbruster wrote: > > - pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, > > + pc_basic_device_init(isa_bus, gsi, &rtc_state, force_fdctrl, &floppy, > > (pc_machine->vmport != ON_OFF_AUTO_ON), 0xff0104); > > > > /* connect pm stuff to lpc */ > > If we can get from MachineState *machine to its MachineClass, Sure you can, it's just MACHINE_GET_CLASS(machine). Paolo > we could > use MachineClass member no_floppy, and not need force_fdctrl. Probably > a wash.