From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxv0V-0000pR-RR for qemu-devel@nongnu.org; Thu, 28 May 2015 06:25:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxv0S-0005WW-Ld for qemu-devel@nongnu.org; Thu, 28 May 2015 06:25:47 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:36234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxv0S-0005WQ-FF for qemu-devel@nongnu.org; Thu, 28 May 2015 06:25:44 -0400 Received: by wgbgq6 with SMTP id gq6so32270971wgb.3 for ; Thu, 28 May 2015 03:25:43 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5566ED24.3060205@redhat.com> Date: Thu, 28 May 2015 12:25:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430133591-6197-1-git-send-email-ghammer@redhat.com> <1430133591-6197-5-git-send-email-ghammer@redhat.com> In-Reply-To: <1430133591-6197-5-git-send-email-ghammer@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine Generation ID device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer , qemu-devel@nongnu.org Cc: imammedo@redhat.com, mst@redhat.com On 27/04/2015 13:19, Gal Hammer wrote: > +static void vmgenid_init(Object *obj) > +{ > + SysBusDevice *sbd = SYS_BUS_DEVICE(obj); > + VmGenIdState *s = VMGENID(obj); > + > + memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vgid", 16); This is a small problem. The spec says the memory of the VMGENID should not be uncacheable, but MMIO _should_ be uncacheable. This is running on a VM so we maybe not care, but it's worth pointing it out. Paolo > + sysbus_init_mmio(sbd, &s->iomem); > + > + object_property_add_str(obj, PROPERTY_UUID, NULL, vmgenid_set_uuid, NULL); > +} > +