From: Michael Tokarev <mjt@tls.msk.ru>
To: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>,
Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo
Date: Thu, 28 May 2015 14:32:10 +0300 [thread overview]
Message-ID: <5566FCBA.2000500@msgid.tls.msk.ru> (raw)
In-Reply-To: <1432632341-5201-1-git-send-email-chenhanxiao@cn.fujitsu.com>
26.05.2015 12:25, Chen Hanxiao wrote:
> s/interation/iteration
>
> Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com>
> ---
> docs/writing-qmp-commands.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/writing-qmp-commands.txt b/docs/writing-qmp-commands.txt
> index f3df206..ab1fdd3 100644
> --- a/docs/writing-qmp-commands.txt
> +++ b/docs/writing-qmp-commands.txt
> @@ -598,7 +598,7 @@ stored in its "value" member. In our example, the "value" member is a pointer
> to an TimerAlarmMethod instance.
>
> Notice that the "current" variable is used as "true" only in the first
> -interation of the loop. That's because the alarm timer method in use is the
> +iteration of the loop. That's because the alarm timer method in use is the
> first element of the alarm_timers array. Also notice that QAPI lists are handled
> by hand and we return the head of the list.
Applied to -trivial, thank you!
Marcus: I don't think such obvious and trivial changes needs to be re-sent
to -devel. Ofcourse it is better to send things to -devel rigth away, but
requiring to resent is a bit over the top. I think anyway :)
/mjt
next parent reply other threads:[~2015-05-28 11:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1432632341-5201-1-git-send-email-chenhanxiao@cn.fujitsu.com>
2015-05-28 11:32 ` Michael Tokarev [this message]
[not found] ` <87twuwaoju.fsf@blackfin.pond.sub.org>
2015-05-28 12:27 ` [Qemu-devel] [PATCH] docs/writing-qmp-commands: fix a typo Michael Tokarev
2015-05-28 14:05 ` Markus Armbruster
2015-05-28 14:08 ` Peter Maydell
2015-05-29 10:16 Chen Hanxiao
2015-06-02 14:38 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566FCBA.2000500@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=armbru@redhat.com \
--cc=chenhanxiao@cn.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).