From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54083)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1YxwRS-0003o1-OZ
	for qemu-devel@nongnu.org; Thu, 28 May 2015 07:57:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1YxwRO-0007MX-OQ
	for qemu-devel@nongnu.org; Thu, 28 May 2015 07:57:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48050)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ghammer@redhat.com>) id 1YxwRO-0007MO-JR
	for qemu-devel@nongnu.org; Thu, 28 May 2015 07:57:38 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 9A55519F230
	for <qemu-devel@nongnu.org>; Thu, 28 May 2015 11:57:37 +0000 (UTC)
Message-ID: <5567030D.8050606@redhat.com>
Date: Thu, 28 May 2015 14:59:09 +0300
From: Gal Hammer <ghammer@redhat.com>
MIME-Version: 1.0
References: <1430133591-6197-1-git-send-email-ghammer@redhat.com>
	<1430133591-6197-5-git-send-email-ghammer@redhat.com>
	<5566ED24.3060205@redhat.com>
In-Reply-To: <5566ED24.3060205@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V15 4/5] i386: add a Virtual Machine
	Generation ID device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, mst@redhat.com

On 28/05/2015 13:25, Paolo Bonzini wrote:
>
>
> On 27/04/2015 13:19, Gal Hammer wrote:
>> +static void vmgenid_init(Object *obj)
>> +{
>> +    SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
>> +    VmGenIdState *s = VMGENID(obj);
>> +
>> +    memory_region_init_io(&s->iomem, obj, &vmgenid_ram_ops, s, "vgid", 16);
>
> This is a small problem.  The spec says the memory of the VMGENID should
> not be uncacheable, but MMIO _should_ be uncacheable.
>
> This is running on a VM so we maybe not care, but it's worth pointing it
> out.

And the way I can fix it would be...? Is there another memory region I 
can use?

Thanks,

     Gal.

> Paolo
>
>> +    sysbus_init_mmio(sbd, &s->iomem);
>> +
>> +    object_property_add_str(obj, PROPERTY_UUID, NULL, vmgenid_set_uuid, NULL);
>> +}
>> +