From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxwcP-000834-NS for qemu-devel@nongnu.org; Thu, 28 May 2015 08:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxwcL-0002jx-RF for qemu-devel@nongnu.org; Thu, 28 May 2015 08:09:01 -0400 Message-ID: <55670521.6090001@huawei.com> Date: Thu, 28 May 2015 20:08:01 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1432811625-13392-1-git-send-email-zhaoshenglong@huawei.com> <1432811625-13392-2-git-send-email-zhaoshenglong@huawei.com> <55670247.5040100@msgid.tls.msk.ru> In-Reply-To: <55670247.5040100@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/4] hw/display/cg3.c: Fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, shannon.zhao@linaro.org On 2015/5/28 19:55, Michael Tokarev wrote: > 28.05.2015 14:13, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > Signed-off-by: Shannon Zhao >> > Signed-off-by: Shannon Zhao >> > --- >> > hw/display/cg3.c | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/hw/display/cg3.c b/hw/display/cg3.c >> > index 1e6ff2b..b86e5c0 100644 >> > --- a/hw/display/cg3.c >> > +++ b/hw/display/cg3.c >> > @@ -302,6 +302,7 @@ static void cg3_realizefn(DeviceState *dev, Error **errp) >> > if (fcode_filename) { >> > ret = load_image_targphys(fcode_filename, s->prom_addr, >> > FCODE_MAX_ROM_SIZE); >> > + g_free(fcode_filename); >> > if (ret < 0 || ret > FCODE_MAX_ROM_SIZE) { >> > error_report("cg3: could not load prom '%s'", CG3_ROM_FILE); >> > } > BTW, here, maybe it is better to rework error message too, > to include the actual filename it tried to load, not the > base name of it. > So respin this and other patches? > Is the error fatal? If CG3_ROM_FILE is removed, it happens. -- Shannon