From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxzB1-0006jT-Vw for qemu-devel@nongnu.org; Thu, 28 May 2015 10:52:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxzAu-0004NG-5G for qemu-devel@nongnu.org; Thu, 28 May 2015 10:52:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxzAu-0004NC-03 for qemu-devel@nongnu.org; Thu, 28 May 2015 10:52:48 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 6420E19F3BB for ; Thu, 28 May 2015 14:52:47 +0000 (UTC) Message-ID: <55672BBE.4090707@redhat.com> Date: Thu, 28 May 2015 08:52:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432815695-31687-1-git-send-email-armbru@redhat.com> <1432815695-31687-4-git-send-email-armbru@redhat.com> In-Reply-To: <1432815695-31687-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tI5uJhce5O9dNW7vtM4E0CUcHpBSFLh4b" Subject: Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tI5uJhce5O9dNW7vtM4E0CUcHpBSFLh4b Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/28/2015 06:21 AM, Markus Armbruster wrote: > Failure to create a -object is a fatal error. However, we delay the s/a -object/an -object/ ? (depends on whether you pronounce '-object' as "object" or "dash-object") > actual exit until all -object are processed. On the one hand, this > permits detection of genuine additional errors. On the other hand, it > can muddy the waters with uninteresting additional errors, e.g. when a > later -object tries to reference a prior one that failed. >=20 > We generally stop right on the first bad option, so do that for > -object as well. >=20 > Signed-off-by: Markus Armbruster > --- > vl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tI5uJhce5O9dNW7vtM4E0CUcHpBSFLh4b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVZyu+AAoJEKeha0olJ0NqX8IIAI3NjGJxvXLm0ai3sx7Omdk0 HWjsqiFLwybTcivOzTXGlIx3+Um+Ez1MAhmH8QZfaokoxpElU3eb3uzYM6aDeRt3 Hcy5FpKl9yuhwjmvSLY23597E3hXxIHL7yzw9uPVIYz8puzZli/P2AOpg2wtf33K 2kDSrUnUHZA7QT4w7nJ6CB4wWZOzeD+KkbybU/12otqubS044pr4cP7exmvyD2Lt WKQ4VmzzF350NUALwA5mbiWaRLkUpxHFFYHZt+q0PcGJnbl/LnZb9XqhmkR78gVA dG9VrTp0gANqy1gzFLQcVtj1T/IlHbDKQyQ83T6jdGOBGUTbW9VIQA7lgZB6+Ps= =ruKU -----END PGP SIGNATURE----- --tI5uJhce5O9dNW7vtM4E0CUcHpBSFLh4b--