From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time
Date: Thu, 28 May 2015 17:04:48 +0200 [thread overview]
Message-ID: <55672E90.4080204@redhat.com> (raw)
In-Reply-To: <w51y4k8g2xt.fsf@maestria.local.igalia.com>
On 28.05.2015 17:02, Alberto Garcia wrote:
> On Thu 28 May 2015 04:56:34 PM CEST, Max Reitz wrote:
>>> 'compat': 'str',
>>> '*lazy-refcounts': 'bool',
>>> '*corrupt': 'bool',
>>> - 'refcount-bits': 'int'
>>> + 'refcount-bits': 'int',
>>> + 'cache-clean-interval': 'int'
>>> } }
>> I'm not too happy about making this part of ImageInfoSpecificQCow2.
>> Two reasons for this: First, it's eventually part of ImageInfo, which
>> is defined as "Information about a QEMU image file", but this option
>> cannot be set in the image file itself but is only a run-time option.
> That's a valid point. Now that I think of it, do we actually have a way
> to retrieve the sizes of the L2 and refcount caches? I think cache-size,
> l2-cache-size, and refcount-cache-size are already write-only values.
No, in fact we don't. Well, except for if you manage to retrieve the
JSON filename for the qcow2 BDS, it should be part of that. :-P
Max
next prev parent reply other threads:[~2015-05-28 15:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 9:46 [Qemu-devel] [PATCH v3 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-27 9:46 ` [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Alberto Garcia
2015-05-27 9:46 ` [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time Alberto Garcia
2015-05-27 12:27 ` Eric Blake
2015-05-27 14:34 ` Alberto Garcia
2015-05-28 14:47 ` Max Reitz
2015-05-28 14:56 ` Max Reitz
2015-05-28 15:02 ` Alberto Garcia
2015-05-28 15:04 ` Max Reitz [this message]
2015-05-28 15:06 ` Max Reitz
2015-05-28 15:13 ` Eric Blake
2015-05-28 15:14 ` Max Reitz
2015-05-28 15:19 ` Alberto Garcia
2015-05-28 15:23 ` Max Reitz
2015-05-28 15:30 ` Alberto Garcia
2015-05-28 19:41 ` Eric Blake
2015-05-29 8:32 ` Kevin Wolf
2015-05-28 16:44 ` Kevin Wolf
2015-05-28 17:03 ` Alberto Garcia
2015-05-27 9:46 ` [Qemu-devel] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding Alberto Garcia
-- strict thread matches above, loose matches on Subject: below --
2015-05-29 9:24 [Qemu-devel] [PATCH v4 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-29 9:24 ` [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time Alberto Garcia
2015-06-02 11:04 ` Kevin Wolf
2015-05-26 17:14 [Qemu-devel] [PATCH v2 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-26 17:14 ` [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time Alberto Garcia
2015-05-26 17:26 ` Max Reitz
2015-05-26 18:52 ` Eric Blake
2015-05-26 19:10 ` Alberto Garcia
2015-05-26 19:15 ` Eric Blake
2015-05-18 16:48 [Qemu-devel] [PATCH 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-18 16:48 ` [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time Alberto Garcia
2015-05-26 16:07 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55672E90.4080204@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).