From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxzMg-00064z-EB for qemu-devel@nongnu.org; Thu, 28 May 2015 11:04:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxzMf-0008Cc-IY for qemu-devel@nongnu.org; Thu, 28 May 2015 11:04:58 -0400 Message-ID: <55672E90.4080204@redhat.com> Date: Thu, 28 May 2015 17:04:48 +0200 From: Max Reitz MIME-Version: 1.0 References: <8007efe81120cd72f7c4145b8bbc3f4bc558e62d.1432719752.git.berto@igalia.com> <55672CA2.10105@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi On 28.05.2015 17:02, Alberto Garcia wrote: > On Thu 28 May 2015 04:56:34 PM CEST, Max Reitz wrote: >>> 'compat': 'str', >>> '*lazy-refcounts': 'bool', >>> '*corrupt': 'bool', >>> - 'refcount-bits': 'int' >>> + 'refcount-bits': 'int', >>> + 'cache-clean-interval': 'int' >>> } } >> I'm not too happy about making this part of ImageInfoSpecificQCow2. >> Two reasons for this: First, it's eventually part of ImageInfo, which >> is defined as "Information about a QEMU image file", but this option >> cannot be set in the image file itself but is only a run-time option. > That's a valid point. Now that I think of it, do we actually have a way > to retrieve the sizes of the L2 and refcount caches? I think cache-size, > l2-cache-size, and refcount-cache-size are already write-only values. No, in fact we don't. Well, except for if you manage to retrieve the JSON filename for the qcow2 BDS, it should be part of that. :-P Max