From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: mst@redhat.com, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, armbru@redhat.com,
"Gabriel L. Somlo" <gsomlo@gmail.com>,
lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither
Date: Thu, 28 May 2015 17:20:57 +0200 [thread overview]
Message-ID: <55673259.7060007@redhat.com> (raw)
In-Reply-To: <1432824960.6250.14.camel@nilsson.home.kraxel.org>
On 28/05/2015 16:56, Gerd Hoffmann wrote:
> > diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> > index d8a8edd..c761291 100644
> > --- a/hw/block/fdc.c
> > +++ b/hw/block/fdc.c
> > @@ -2186,7 +2186,7 @@ static void fdctrl_realize_common(FDCtrl *fdctrl, Error **errp)
> > }
> >
> > static const MemoryRegionPortio fdc_portio_list[] = {
> > - { 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write },
> > + { 0, 6, 1, .read = fdctrl_read, .write = fdctrl_write },
> > { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write },
> > PORTIO_END_OF_LIST(),
> > };
>
> The io ranges for FDC0 in hw/i386/acpi-dsdt-isa.dsl are not consistent
> with that though. If 0x3f0 is correct (which seems to be the case from
> a brief look) this needs to be fixed up.
Agreed. Who draws the short straw? :)
Paolo
next prev parent reply other threads:[~2015-05-28 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:06 [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted Laszlo Ersek
2015-05-28 8:19 ` Paolo Bonzini
2015-05-28 8:39 ` Markus Armbruster
2015-05-28 8:42 ` Paolo Bonzini
2015-05-28 9:38 ` Michael S. Tsirkin
2015-05-28 9:30 ` Kevin Wolf
2015-05-28 12:59 ` [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither Gabriel L. Somlo
2015-05-28 13:52 ` Gerd Hoffmann
2015-05-28 14:42 ` Paolo Bonzini
2015-05-28 14:56 ` Gerd Hoffmann
2015-05-28 15:20 ` Paolo Bonzini [this message]
2015-05-28 15:49 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55673259.7060007@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=gsomlo@gmail.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).