From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxzcI-0001uU-OC for qemu-devel@nongnu.org; Thu, 28 May 2015 11:21:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxzcE-0006Cu-Gw for qemu-devel@nongnu.org; Thu, 28 May 2015 11:21:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxzcE-0006Ck-6C for qemu-devel@nongnu.org; Thu, 28 May 2015 11:21:02 -0400 Message-ID: <55673259.7060007@redhat.com> Date: Thu, 28 May 2015 17:20:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150528125925.GG6488@HEDWIG.INI.CMU.EDU> <1432821161.6250.11.camel@nilsson.home.kraxel.org> <55672949.5000502@redhat.com> <1432824960.6250.14.camel@nilsson.home.kraxel.org> In-Reply-To: <1432824960.6250.14.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: mst@redhat.com, John Snow , qemu-devel@nongnu.org, armbru@redhat.com, "Gabriel L. Somlo" , lersek@redhat.com On 28/05/2015 16:56, Gerd Hoffmann wrote: > > diff --git a/hw/block/fdc.c b/hw/block/fdc.c > > index d8a8edd..c761291 100644 > > --- a/hw/block/fdc.c > > +++ b/hw/block/fdc.c > > @@ -2186,7 +2186,7 @@ static void fdctrl_realize_common(FDCtrl *fdctrl, Error **errp) > > } > > > > static const MemoryRegionPortio fdc_portio_list[] = { > > - { 1, 5, 1, .read = fdctrl_read, .write = fdctrl_write }, > > + { 0, 6, 1, .read = fdctrl_read, .write = fdctrl_write }, > > { 7, 1, 1, .read = fdctrl_read, .write = fdctrl_write }, > > PORTIO_END_OF_LIST(), > > }; > > The io ranges for FDC0 in hw/i386/acpi-dsdt-isa.dsl are not consistent > with that though. If 0x3f0 is correct (which seems to be the case from > a brief look) this needs to be fixed up. Agreed. Who draws the short straw? :) Paolo