Re: [Qemu-devel] [PATCH 2/4] iotests: Add dependency info to groups list

[John Snow <jsnow@redhat.com>]

On 05/27/2015 11:34 PM, Fam Zheng wrote:
> On Fri, 05/22 16:17, John Snow wrote:
>> Add a few external dependency groups to the iotests groups list,
>> such as "qemu", "nbd", and "scm".
>>
>> This will assist us in knowing which tests need to be re-run
>> when those dependencies are updated, or by helping us to avoid
>> tests that we know are broken for a certain file.
>>
>> qemu-img and qemu-io are so ubiquitous that it's not worth
>> amending this information to the groups file.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
> 
> 007 uses $QEMU too ;-) Others looks good.
> 

Hm, nuts... I actually tried to double check my work by deleting the
binary and seeing what tests failed/passed, but I missed this one.

Will fix up for v2, thanks.

> Reviewed-by: Fam Zheng <famz@redhat.com>
> 
>> ---
>>  tests/qemu-iotests/group | 60 ++++++++++++++++++++++++------------------------
>>  1 file changed, 30 insertions(+), 30 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
>> index 34b16cb..32f15d8 100644
>> --- a/tests/qemu-iotests/group
>> +++ b/tests/qemu-iotests/group
>> @@ -34,9 +34,9 @@
>>  025 rw auto quick
>>  026 rw blkdbg auto
>>  027 rw auto quick
>> -028 rw backing auto quick
>> +028 rw backing auto quick qemu
>>  029 rw auto quick
>> -030 rw auto backing
>> +030 rw auto backing qemu
>>  031 rw auto quick
>>  032 rw auto quick
>>  033 rw auto quick
>> @@ -46,38 +46,38 @@
>>  037 rw auto backing quick
>>  038 rw auto backing quick
>>  039 rw auto quick
>> -040 rw auto
>> -041 rw auto backing
>> +040 rw auto qemu
>> +041 rw auto backing qemu
>>  042 rw auto quick
>>  043 rw auto backing
>>  044 rw auto
>> -045 rw auto quick
>> +045 rw auto quick scm qemu
>>  046 rw auto aio quick
>>  047 rw auto quick
>>  048 img auto quick
>>  049 rw auto
>>  050 rw auto backing quick
>> -051 rw auto
>> +051 rw auto qemu
>>  052 rw auto backing quick
>>  053 rw auto quick
>>  054 rw auto quick
>> -055 rw auto
>> -056 rw auto backing
>> -057 rw auto
>> -058 rw auto quick
>> +055 rw auto qemu
>> +056 rw auto backing qemu
>> +057 rw auto qemu
>> +058 rw auto quick nbd
>>  059 rw auto quick
>>  060 rw auto quick
>>  061 rw auto
>>  062 rw auto quick
>>  063 rw auto quick
>>  064 rw auto quick
>> -065 rw auto quick
>> +065 rw auto quick qemu
>>  066 rw auto quick
>> -067 rw auto quick
>> -068 rw auto quick
>> +067 rw auto quick qemu
>> +068 rw auto quick qemu
>>  069 rw auto quick
>>  070 rw auto quick
>> -071 rw auto quick
>> +071 rw auto quick qemu
>>  072 rw auto quick
>>  073 rw auto quick
>>  074 rw auto quick
>> @@ -87,45 +87,45 @@
>>  078 rw auto quick
>>  079 rw auto
>>  080 rw auto
>> -081 rw auto quick
>> +081 rw auto quick qemu
>>  082 rw auto quick
>> -083 rw auto
>> +083 rw auto nbd
>>  084 img auto quick
>> -085 rw auto
>> +085 rw auto qemu
>>  086 rw auto quick
>> -087 rw auto quick
>> +087 rw auto quick qemu
>>  088 rw auto quick
>>  089 rw auto quick
>>  090 rw auto quick
>> -091 rw auto
>> +091 rw auto qemu
>>  092 rw auto quick
>> -093 auto
>> -094 rw auto quick
>> -095 rw auto quick
>> +093 auto qemu
>> +094 rw auto quick qemu nbd
>> +095 rw auto quick qemu
>>  097 rw auto backing
>>  098 rw auto backing quick
>> -099 rw auto quick
>> +099 rw auto quick qemu
>>  100 rw auto quick
>>  101 rw auto quick
>> -102 rw auto quick
>> +102 rw auto quick qemu
>>  103 rw auto quick
>>  104 rw auto
>>  105 rw auto quick
>>  107 rw auto quick
>>  108 rw auto quick
>> -109 rw auto
>> +109 rw auto qemu
>>  110 rw auto backing quick
>>  111 rw auto quick
>>  112 rw auto
>> -113 rw auto quick
>> +113 rw auto quick nbd
>>  114 rw auto quick
>>  115 rw auto
>>  116 rw auto quick
>>  121 rw auto
>>  122 rw auto
>> -123 rw auto quick
>> -124 rw auto backing
>> +123 rw auto quick nbd
>> +124 rw auto backing qemu
>>  128 rw auto quick
>> -129 rw auto quick
>> -130 rw auto quick
>> +129 rw auto quick qemu
>> +130 rw auto quick qemu
>>  131 rw auto quick
>> -- 
>> 2.1.0
>>

-- 
—js