From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yy36o-00088A-84 for qemu-devel@nongnu.org; Thu, 28 May 2015 15:04:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yy36k-0003Gv-Sa for qemu-devel@nongnu.org; Thu, 28 May 2015 15:04:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yy36k-0003Gr-Mt for qemu-devel@nongnu.org; Thu, 28 May 2015 15:04:46 -0400 Message-ID: <556766CC.9040705@redhat.com> Date: Thu, 28 May 2015 15:04:44 -0400 From: John Snow MIME-Version: 1.0 References: <1432749229-4861-1-git-send-email-armbru@redhat.com> In-Reply-To: <1432749229-4861-1-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com On 05/27/2015 01:53 PM, Markus Armbruster wrote: > Since we now require GLib 2.22+ (commit f40685c), we don't have to > work around lack of g_strcmp0() anymore. > > This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1. > > Conflicts: > qemu-ga.c > > Signed-off-by: Markus Armbruster > --- > qga/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/main.c b/qga/main.c > index 9939a2b..0b788e1 100644 > --- a/qga/main.c > +++ b/qga/main.c > @@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level, > > level &= G_LOG_LEVEL_MASK; > #ifndef _WIN32 > - if (domain && strcmp(domain, "syslog") == 0) { > + if (g_strcmp0(domain, "syslog") == 0) { > syslog(LOG_INFO, "%s: %s", level_str, msg); > } else if (level & s->log_level) { > #else > Reviewed-by: John Snow