* [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
@ 2015-05-27 17:53 Markus Armbruster
2015-05-28 19:04 ` John Snow
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-05-27 17:53 UTC (permalink / raw)
To: qemu-devel; +Cc: mdroth
Since we now require GLib 2.22+ (commit f40685c), we don't have to
work around lack of g_strcmp0() anymore.
This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.
Conflicts:
qemu-ga.c
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qga/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/main.c b/qga/main.c
index 9939a2b..0b788e1 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level,
level &= G_LOG_LEVEL_MASK;
#ifndef _WIN32
- if (domain && strcmp(domain, "syslog") == 0) {
+ if (g_strcmp0(domain, "syslog") == 0) {
syslog(LOG_INFO, "%s: %s", level_str, msg);
} else if (level & s->log_level) {
#else
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
2015-05-27 17:53 [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" Markus Armbruster
@ 2015-05-28 19:04 ` John Snow
2015-06-16 6:34 ` Markus Armbruster
2015-06-18 12:47 ` Michael Tokarev
2 siblings, 0 replies; 6+ messages in thread
From: John Snow @ 2015-05-28 19:04 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: mdroth
On 05/27/2015 01:53 PM, Markus Armbruster wrote:
> Since we now require GLib 2.22+ (commit f40685c), we don't have to
> work around lack of g_strcmp0() anymore.
>
> This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.
>
> Conflicts:
> qemu-ga.c
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qga/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 9939a2b..0b788e1 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level,
>
> level &= G_LOG_LEVEL_MASK;
> #ifndef _WIN32
> - if (domain && strcmp(domain, "syslog") == 0) {
> + if (g_strcmp0(domain, "syslog") == 0) {
> syslog(LOG_INFO, "%s: %s", level_str, msg);
> } else if (level & s->log_level) {
> #else
>
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
2015-05-27 17:53 [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" Markus Armbruster
2015-05-28 19:04 ` John Snow
@ 2015-06-16 6:34 ` Markus Armbruster
2015-06-18 11:55 ` Markus Armbruster
2015-07-07 1:33 ` Michael Roth
2015-06-18 12:47 ` Michael Tokarev
2 siblings, 2 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-06-16 6:34 UTC (permalink / raw)
To: qemu-devel; +Cc: mdroth
Ping?
Markus Armbruster <armbru@redhat.com> writes:
> Since we now require GLib 2.22+ (commit f40685c), we don't have to
> work around lack of g_strcmp0() anymore.
>
> This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.
>
> Conflicts:
> qemu-ga.c
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qga/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/main.c b/qga/main.c
> index 9939a2b..0b788e1 100644
> --- a/qga/main.c
> +++ b/qga/main.c
> @@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level,
>
> level &= G_LOG_LEVEL_MASK;
> #ifndef _WIN32
> - if (domain && strcmp(domain, "syslog") == 0) {
> + if (g_strcmp0(domain, "syslog") == 0) {
> syslog(LOG_INFO, "%s: %s", level_str, msg);
> } else if (level & s->log_level) {
> #else
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
2015-06-16 6:34 ` Markus Armbruster
@ 2015-06-18 11:55 ` Markus Armbruster
2015-07-07 1:33 ` Michael Roth
1 sibling, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-06-18 11:55 UTC (permalink / raw)
To: qemu-trivial; +Cc: mdroth, qemu-devel
Falling back to qemu-trivial, hope that's okay.
Markus Armbruster <armbru@redhat.com> writes:
> Ping?
>
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Since we now require GLib 2.22+ (commit f40685c), we don't have to
>> work around lack of g_strcmp0() anymore.
>>
>> This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.
>>
>> Conflicts:
>> qemu-ga.c
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> qga/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/qga/main.c b/qga/main.c
>> index 9939a2b..0b788e1 100644
>> --- a/qga/main.c
>> +++ b/qga/main.c
>> @@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level,
>>
>> level &= G_LOG_LEVEL_MASK;
>> #ifndef _WIN32
>> - if (domain && strcmp(domain, "syslog") == 0) {
>> + if (g_strcmp0(domain, "syslog") == 0) {
>> syslog(LOG_INFO, "%s: %s", level_str, msg);
>> } else if (level & s->log_level) {
>> #else
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
2015-06-16 6:34 ` Markus Armbruster
2015-06-18 11:55 ` Markus Armbruster
@ 2015-07-07 1:33 ` Michael Roth
1 sibling, 0 replies; 6+ messages in thread
From: Michael Roth @ 2015-07-07 1:33 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
Quoting Markus Armbruster (2015-06-16 01:34:57)
> Ping?
Applied, thanks.
>
> Markus Armbruster <armbru@redhat.com> writes:
>
> > Since we now require GLib 2.22+ (commit f40685c), we don't have to
> > work around lack of g_strcmp0() anymore.
> >
> > This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1.
> >
> > Conflicts:
> > qemu-ga.c
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> > qga/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qga/main.c b/qga/main.c
> > index 9939a2b..0b788e1 100644
> > --- a/qga/main.c
> > +++ b/qga/main.c
> > @@ -274,7 +274,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level,
> >
> > level &= G_LOG_LEVEL_MASK;
> > #ifndef _WIN32
> > - if (domain && strcmp(domain, "syslog") == 0) {
> > + if (g_strcmp0(domain, "syslog") == 0) {
> > syslog(LOG_INFO, "%s: %s", level_str, msg);
> > } else if (level & s->log_level) {
> > #else
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"
2015-05-27 17:53 [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" Markus Armbruster
2015-05-28 19:04 ` John Snow
2015-06-16 6:34 ` Markus Armbruster
@ 2015-06-18 12:47 ` Michael Tokarev
2 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-06-18 12:47 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: mdroth
27.05.2015 20:53, Markus Armbruster wrote:
> Since we now require GLib 2.22+ (commit f40685c), we don't have to
> work around lack of g_strcmp0() anymore.
> qga/main.c | 2 +-
> - if (domain && strcmp(domain, "syslog") == 0) {
> + if (g_strcmp0(domain, "syslog") == 0) {
Why bother? To me the current version is easier to read,
it is traditional and working, while for g_strcmp0() I
have to look up documentation.
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-07 1:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 17:53 [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage" Markus Armbruster
2015-05-28 19:04 ` John Snow
2015-06-16 6:34 ` Markus Armbruster
2015-06-18 11:55 ` Markus Armbruster
2015-07-07 1:33 ` Michael Roth
2015-06-18 12:47 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).