From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yy9yw-0004EP-4v for qemu-devel@nongnu.org; Thu, 28 May 2015 22:25:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yy9yv-00023l-Bj for qemu-devel@nongnu.org; Thu, 28 May 2015 22:25:10 -0400 Message-ID: <5567CD12.9040106@huawei.com> Date: Fri, 29 May 2015 10:21:06 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> <55670B48.20106@msgid.tls.msk.ru> In-Reply-To: <55670B48.20106@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/29] Fix memory leak relevant to calling qemu_allocate_irqs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, shannon.zhao@linaro.org, peter.maydell@linaro.org On 2015/5/28 20:34, Michael Tokarev wrote: > 28.05.2015 15:08, Shannon Zhao wrote: >> From: Shannon Zhao >> >> Before I sent some patches to fix memory leak spotted by valgrind and >> those are relevant to qemu_allocate_irqs. Then I find all the places >> calling this function through code searching and test by valgrind to >> check whether they have memory leak. These patches fix these memory leaks. >> >> Sorry that maybe the names of the patches are vertiginous while I could >> not find out better names and I try to sort them out. > > Maybe a better subject will be "fix memory leak after qemu_allocate_irqs" > or something like that? And for some, "use qemu_allocate_irq not _irqs > for single irq" -- this kind is sorta fun, I wonder why the codebase has > so many cases of this API misuse. > > And one more question: do you really care that whole valgrind report is > included into every commit message? :) not really, while these reports show people the problems. You could deal them in your way. Thanks, -- Shannon