From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyErQ-0003oX-KP for qemu-devel@nongnu.org; Fri, 29 May 2015 03:37:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyErN-0006Ym-G0 for qemu-devel@nongnu.org; Fri, 29 May 2015 03:37:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyErN-0006XP-AL for qemu-devel@nongnu.org; Fri, 29 May 2015 03:37:41 -0400 Message-ID: <55681741.5080909@redhat.com> Date: Fri, 29 May 2015 09:37:37 +0200 From: Michal Privoznik MIME-Version: 1.0 References: <8c75b9fdf0d95c02292507e50abe3176f414bf3a.1429256889.git.chen.fan.fnst@cn.fujitsu.com> In-Reply-To: <8c75b9fdf0d95c02292507e50abe3176f414bf3a.1429256889.git.chen.fan.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 4/7] qemu-agent: add qemuAgentCreateBond interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan , libvir-list@redhat.com Cc: izumi.taku@jp.fujitsu.com, qemu-devel@nongnu.org On 17.04.2015 10:53, Chen Fan wrote: > via initialize callback to create bond device. > > Signed-off-by: Chen Fan > --- > src/qemu/qemu_agent.c | 118 ++++++++++++++++++++++++++++++++++++++++++++++++ > src/qemu/qemu_agent.h | 10 ++++ > src/qemu/qemu_domain.c | 70 ++++++++++++++++++++++++++++ > src/qemu/qemu_domain.h | 7 +++ > src/qemu/qemu_process.c | 4 ++ > 5 files changed, 209 insertions(+) > If we go this way, we should introduce much broader set of interface types to create. In fact, I don't like idea of qemu-ga mangling guest network, esp. when there are so many tools for that. Michal