From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52687)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YyIDH-0007SI-3r
	for qemu-devel@nongnu.org; Fri, 29 May 2015 07:12:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YyIDC-0005Sy-0X
	for qemu-devel@nongnu.org; Fri, 29 May 2015 07:12:31 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <55684995.3070205@redhat.com>
Date: Fri, 29 May 2015 13:12:21 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1432897012-1423-1-git-send-email-alex.bennee@linaro.org>
In-Reply-To: <1432897012-1423-1-git-send-email-alex.bennee@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags
	sets -O
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org



On 29/05/2015 12:56, Alex Bennée wrote:
> If your trying to debug and want to force -O0 then don't allow the
> configure script to try and set -O2. You can use --enable-debug but that
> enables a lot more stuff by default.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  configure | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index b707429..be1f354 100755
> --- a/configure
> +++ b/configure
> @@ -4240,7 +4240,10 @@ if test "$gcov" = "yes" ; then
>    CFLAGS="-fprofile-arcs -ftest-coverage -g $CFLAGS"
>    LDFLAGS="-fprofile-arcs -ftest-coverage $LDFLAGS"
>  elif test "$debug" = "no" ; then
> -  CFLAGS="-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
> +    if test "${EXTRA_CFLAGS#*-O}" = "$EXTRA_CFLAGS"; then
> +        CFLAGS="-O2 $CFLAGS"
> +    fi
> +    CFLAGS="-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 $CFLAGS"
>  fi
>  
>  ##########################################
> 

Why aren't EXTRA_CFLAGS applied _after_ CFLAGS instead of before?

Paolo