From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode()
Date: Fri, 29 May 2015 08:05:27 -0600 [thread overview]
Message-ID: <55687227.1000904@redhat.com> (raw)
In-Reply-To: <1432893420-18687-12-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On 05/29/2015 03:56 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> monitor.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-05-29 14:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 9:56 [Qemu-devel] [PATCH v3 00/21] monitor: Wean core off QError, and other cleanups Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 01/21] monitor: Drop broken, unused asynchronous command interface Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 02/21] monitor: Clean up after previous commit Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 03/21] monitor: Improve and document client_migrate_info protocol error Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 04/21] monitor: Convert client_migrate_info to QAPI Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 05/21] monitor: Use traditional command interface for HMP drive_del Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 06/21] monitor: Use traditional command interface for HMP device_add Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 07/21] monitor: Use trad. command interface for HMP pcie_aer_inject_error Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 08/21] monitor: Drop unused "new" HMP command interface Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 09/21] monitor: Propagate errors through qmp_check_client_args() Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 10/21] monitor: Propagate errors through qmp_check_input_obj() Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 11/21] monitor: Propagate errors through invalid_qmp_mode() Markus Armbruster
2015-05-29 13:58 ` Luiz Capitulino
2015-05-29 14:19 ` Markus Armbruster
2015-05-29 14:27 ` Luiz Capitulino
2015-05-29 14:05 ` Eric Blake [this message]
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 12/21] monitor: Wean monitor_protocol_emitter() off mon->error Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 13/21] monitor: Inline monitor_has_error() into its only caller Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 14/21] monitor: Limit QError use to command handlers Markus Armbruster
2015-05-29 14:23 ` Markus Armbruster
2015-05-29 14:27 ` Luiz Capitulino
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 15/21] monitor: Rename handle_user_command() to handle_hmp_command() Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 16/21] monitor: Rename monitor_control_read(), monitor_control_event() Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 17/21] monitor: Unbox Monitor member mc and rename to qmp Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 18/21] monitor: Drop do_qmp_capabilities()'s superfluous QMP check Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 19/21] monitor: Turn int command_mode into bool in_command_mode Markus Armbruster
2015-05-29 9:56 ` [Qemu-devel] [PATCH v3 20/21] monitor: Rename monitor_ctrl_mode() to monitor_is_qmp() Markus Armbruster
2015-05-29 9:57 ` [Qemu-devel] [PATCH v3 21/21] monitor: Change return type of monitor_cur_is_qmp() to bool Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55687227.1000904@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).