From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyMLS-0006ob-7D for qemu-devel@nongnu.org; Fri, 29 May 2015 11:37:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyMLP-0000KI-2x for qemu-devel@nongnu.org; Fri, 29 May 2015 11:37:14 -0400 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:34712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyMLO-0000KE-SV for qemu-devel@nongnu.org; Fri, 29 May 2015 11:37:11 -0400 Received: by wgv5 with SMTP id 5so66006592wgv.1 for ; Fri, 29 May 2015 08:37:10 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556887A1.20508@redhat.com> Date: Fri, 29 May 2015 17:37:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432911708-22845-1-git-send-email-dgilbert@redhat.com> <1432911708-22845-3-git-send-email-dgilbert@redhat.com> In-Reply-To: <1432911708-22845-3-git-send-email-dgilbert@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, armbru@redhat.com, mst@redhat.com On 29/05/2015 17:01, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Newer glib has support for checking that applications aren't > using newer glib calls than they should be. > > The support for the check only went into glib 2.32 and it only > has macros for version 2.26 upwards; although we only insist > on 2.22 at the moment, I set the glib checks to the earliest of 2.26, > it wont cause problems on anything <2.32 since the checks aren't > there. I think we need 2.32 minimum, because we use the 2.32 mutex/condvar functions if available. Paolo