From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O
Date: Fri, 29 May 2015 18:29:15 +0200 [thread overview]
Message-ID: <556893DB.9030502@redhat.com> (raw)
In-Reply-To: <877frrii83.fsf@linaro.org>
On 29/05/2015 16:14, Alex Bennée wrote:
> You mean just do:
>
> diff --git a/configure b/configure
> index b707429..f13831a 100755
> --- a/configure
> +++ b/configure
> @@ -353,7 +353,7 @@ for opt do
> ;;
> --cpu=*) cpu="$optarg"
> ;;
> - --extra-cflags=*) QEMU_CFLAGS="$optarg $QEMU_CFLAGS"
> + --extra-cflags=*) QEMU_CFLAGS="$QEMU_CFLAGS $optarg"
> EXTRA_CFLAGS="$optarg"
> ;;
> --extra-ldflags=*) LDFLAGS="$optarg $LDFLAGS"
>
> I guess at the time I was trying to be clean and avoiding multiple -O
> calls. But I guess that will have the same effect.
Yes, that. Most other QEMU_CFLAGS assignments add at the beginning, so
I guess the remaining ones (including the --extra-cflags one) should too.
Paolo
next prev parent reply other threads:[~2015-05-29 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 10:56 [Qemu-devel] [PATCH] configure: don't apply -O2 if extra-cflags sets -O Alex Bennée
2015-05-29 11:12 ` Paolo Bonzini
2015-05-29 14:14 ` Alex Bennée
2015-05-29 16:29 ` Paolo Bonzini [this message]
2015-06-02 5:48 ` Michael Tokarev
2015-06-02 8:01 ` Alex Bennée
2015-06-02 14:08 ` Paolo Bonzini
2015-06-03 8:57 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556893DB.9030502@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).