From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyNIu-0001WX-QS for qemu-devel@nongnu.org; Fri, 29 May 2015 12:38:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YyNIp-0002Qc-OP for qemu-devel@nongnu.org; Fri, 29 May 2015 12:38:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YyNIp-0002QN-Jy for qemu-devel@nongnu.org; Fri, 29 May 2015 12:38:35 -0400 Message-ID: <55689605.8070308@redhat.com> Date: Fri, 29 May 2015 18:38:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1432912446-9811-1-git-send-email-victor.clement@openwide.fr> <1432912446-9811-4-git-send-email-victor.clement@openwide.fr> In-Reply-To: <1432912446-9811-4-git-send-email-victor.clement@openwide.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] icount: print a warning if there is no more deadline in sleep=no mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Victor CLEMENT , qemu-devel@nongnu.org Cc: francois.guerret@hotmail.fr, julien.viarddegalbert@openwide.fr On 29/05/2015 17:14, Victor CLEMENT wrote: > While qemu is running in sleep=no mode, a warning will be printed > when no timer deadline is set. > As this mode is intended for getting deterministic virtual time, if no > timer is set on the virtual clock this determinism is broken. > > Signed-off-by: Victor CLEMENT > --- > cpus.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/cpus.c b/cpus.c > index 4e90e63..aec17b6 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -419,6 +419,12 @@ void qemu_clock_warp(QEMUClockType type) > clock = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL_RT); > deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL); > if (deadline < 0) { > + static bool notified; > + if (!icount_sleep && !notified) { > + fprintf(stderr, "cpus: WARNING: icount sleep disabled and no more \ > +active timer\n"); I'm changing this to error_report, and queuing the series for 2.4 with no other changes. Expect it to be in a pull request next week! Paolo > + notified = true; > + } > return; > } > >