From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60310) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKhF-0004CM-V1 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:03:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzKhA-0003Q1-UG for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:03:45 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:37584) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKhA-0003Pn-LW for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:03:40 -0400 Received: by wifw1 with SMTP id w1so94073353wif.0 for ; Mon, 01 Jun 2015 01:03:40 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556C11D1.4080301@redhat.com> Date: Mon, 01 Jun 2015 10:03:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 15/34] HACK: monitor: Comment out TCG profile ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite On 31/05/2015 08:11, Peter Crosthwaite wrote: > Not dealing with this problem as of this RFC, but comments on how > to solve it welcome. The approach adopted by this series is to > implement multi-arch as multiple translators, so a single global > TCG profiler is now ill-defined. Probably some kind of tcg-common.c? The counts can be added together for all CPUs, and hence moved out of tcg_ctx. Also for example tcg/tcg-opc.h should only depend on TCG_TARGET_REG_BITS, i.e. not on the arch. Hence tcg_op_defs should also be arch-independent. Paolo > Signed-off-by: Peter Crosthwaite > --- > monitor.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/monitor.c b/monitor.c > index 1a17cf3..f3ee785 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1036,13 +1036,17 @@ static void hmp_info_registers(Monitor *mon, const QDict *qdict) > > static void hmp_info_jit(Monitor *mon, const QDict *qdict) > { > +#if 0 > dump_exec_info((FILE *)mon, monitor_fprintf); > +#endif > dump_drift_info((FILE *)mon, monitor_fprintf); > } > > static void hmp_info_opcount(Monitor *mon, const QDict *qdict) > { > +#if 0 > dump_opcount_info((FILE *)mon, monitor_fprintf); > +#endif > } > > static void hmp_info_history(Monitor *mon, const QDict *qdict) >