From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKi9-00051X-U2 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:04:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzKi4-0003dK-VM for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:04:41 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:38612) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKi4-0003dE-OV for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:04:36 -0400 Received: by wizo1 with SMTP id o1so93969136wiz.1 for ; Mon, 01 Jun 2015 01:04:36 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556C1204.4030107@redhat.com> Date: Mon, 01 Jun 2015 10:04:20 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <5761e5b785437713ac9bf237fcc5f63e9749e9e0.1433052532.git.crosthwaite.peter@gmail.com> In-Reply-To: <5761e5b785437713ac9bf237fcc5f63e9749e9e0.1433052532.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 16/34] HACK: Disable list_cpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite On 31/05/2015 08:11, Peter Crosthwaite wrote: > Not dealing with this issue as of this RFC. Comments welcome on how to > handle it. It is probably a case that any form of CPU selection is ill > defined in multi-arch. So just a case of #ifndef TARGET_MULTI or > something like that? That, or handle it like tcg_exec_init? Paolo > Signed-off-by: Peter Crosthwaite > --- > cpus.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/cpus.c b/cpus.c > index 2dc4a9a..441a026 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -1446,9 +1446,11 @@ void cpu_loop_exit(CPUState *cpu) > void list_cpus(FILE *f, fprintf_function cpu_fprintf, const char *optarg) > { > /* XXX: implement xxx_cpu_list for targets that still miss it */ > +#if 0 > #if defined(cpu_list) > cpu_list(f, cpu_fprintf); > #endif > +#endif > } > > CpuInfoList *qmp_query_cpus(Error **errp) >