From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKmW-0006KI-EA for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:09:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzKmS-0005JZ-DR for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:09:12 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:34012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKmS-0005JT-6E for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:09:08 -0400 Received: by wibut5 with SMTP id ut5so30614834wib.1 for ; Mon, 01 Jun 2015 01:09:07 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556C1319.1040900@redhat.com> Date: Mon, 01 Jun 2015 10:08:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <3b40190715e7e7e0bfaa7d9c77a846745712c303.1433052532.git.crosthwaite.peter@gmail.com> In-Reply-To: <3b40190715e7e7e0bfaa7d9c77a846745712c303.1433052532.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 19/34] HACK: disas: Defeature print_target_address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite On 31/05/2015 08:11, Peter Crosthwaite wrote: > It does not work in multi-arch as it requires the CPU specific > TARGET_VIRT_ADDR_SPACE_BITS global define. Just use the generic > version that does no masking. If this masking is still needed (??) > then the variable can be virtualised in the CPUState. > > Signed-off-by: Peter Crosthwaite This is a user-mode only thing. So this patch is okay if conditionalized on CONFIG_USER_ONLY. Paolo