From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33603)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YzKpE-0001JV-PW
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:12:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YzKpA-0006mo-PC
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:12:00 -0400
Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:37542)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YzKpA-0006mh-Ip
	for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:11:56 -0400
Received: by wifw1 with SMTP id w1so94337010wif.0
	for <qemu-devel@nongnu.org>; Mon, 01 Jun 2015 01:11:56 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <556C13B1.4010504@redhat.com>
Date: Mon, 01 Jun 2015 10:11:29 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1433052532.git.crosthwaite.peter@gmail.com>
	<e4576fb0247e2b6c89920df12a4192a033aa384d.1433052532.git.crosthwaite.peter@gmail.com>
In-Reply-To: <e4576fb0247e2b6c89920df12a4192a033aa384d.1433052532.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v2 21/34] core: virtualise CPU interfaces
	completely
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, rth@twiddle.net, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite <crosthwaite.peter@gmail.com>



On 31/05/2015 08:11, Peter Crosthwaite wrote:
>      }
> -    ret = cpu_exec(cpu);
> +    ret = cpu->cpu_exec(cpu);

Perhaps a

#ifdef TARGET_MULTI
#define MULTI_CPU_HOOK(cpu, fn) (cpu->fn)
#else
#define MULTI_CPU_HOOK(cpu, fn) (fn)
#endif

to devirtualize the functions in the common case?

Paolo

>  #ifdef CONFIG_PROFILER
>      tcg_time += profile_getclock() - ti;
>  #endif
> @@ -1433,7 +1433,7 @@ void cpu_reload_memory_map(CPUState *cpu)
>      /* The CPU and TLB are protected by the iothread lock.  */
>      d = atomic_rcu_read(&cpu->as->dispatch);
>      cpu->memory_dispatch = d;
> -    tlb_flush(cpu, 1);
> +    cpu->tlb_flush(cpu, 1);
>  }
>  #endif