From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKw9-0004dn-QW for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:19:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzKw4-0000n7-FJ for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:19:09 -0400 Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:34865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzKw4-0000mm-7o for qemu-devel@nongnu.org; Mon, 01 Jun 2015 04:19:04 -0400 Received: by wgme6 with SMTP id e6so107268767wgm.2 for ; Mon, 01 Jun 2015 01:19:03 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556C156F.1000801@redhat.com> Date: Mon, 01 Jun 2015 10:18:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 23/34] arm: cpu: static inline cpu_arm_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite On 31/05/2015 08:11, Peter Crosthwaite wrote: > Move this implementation up to the header so it is visible from system > level code once the architecture is converted to arch-obj-y. Alternative > would be to create init.c in target-arm/hw but this implementation is > trivial enough for static inline. > > Signed-off-by: Peter Crosthwaite > --- > target-arm/cpu.h | 6 +++++- > target-arm/helper.c | 5 ----- > 2 files changed, 5 insertions(+), 6 deletions(-) I think there is something to win from consistency when you have a partial transition, so perhaps target-arm/hw would be better despite the simplicity of the function... Paolo