From: Yongbok Kim <yongbok.kim@imgtec.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing
Date: Mon, 1 Jun 2015 10:42:46 +0100 [thread overview]
Message-ID: <556C2916.7000609@imgtec.com> (raw)
In-Reply-To: <1432920900-11047-1-git-send-email-rth@twiddle.net>
On 29/05/2015 18:35, Richard Henderson wrote:
> The addition of MO_AMASK means that places that used inverted masks
> need to be changed to use positive masks, and places that failed to
> mask the intended bits need updating.
>
> Cc: Yongbok Kim <yongbok.kim@imgtec.com>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>
> This should fix the problem you found while testing the mipsr6
> unaligned memory ops patch set.
>
>
> r~
I have noticed that you haven't changed it for the tci, is it deliberate?
Another minor thing is that tcg_dump_ops() in tcg.c wouldn't print ld/st
names correctly but hex code will be printed out.
Otherwise,
Reviewed-by: Yongbok Kim <yongbok.kim@imgtec.com>
Regards,
Yongbok
next prev parent reply other threads:[~2015-06-01 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 17:35 [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing Richard Henderson
2015-06-01 9:42 ` Yongbok Kim [this message]
2015-06-01 15:28 ` Richard Henderson
2015-06-08 11:10 ` Yongbok Kim
2015-06-08 17:32 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2015-06-09 21:12 [Qemu-devel] [PATCH 0/3] target-alpha PALcode improvements Richard Henderson
2015-06-09 21:12 ` [Qemu-devel] [PATCH] tcg: Mask TCGMemOp appropriately for indexing Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C2916.7000609@imgtec.com \
--to=yongbok.kim@imgtec.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).