From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: matt.fleming@intel.com, "Gabriel L. Somlo" <somlo@cmu.edu>,
qemu-devel@nongnu.org, gsomlo@gmail.com, kraxel@redhat.com,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline
Date: Mon, 01 Jun 2015 12:50:50 +0200 [thread overview]
Message-ID: <556C390A.7090706@redhat.com> (raw)
In-Reply-To: <20150601124604-mutt-send-email-mst@redhat.com>
On 01/06/2015 12:48, Michael S. Tsirkin wrote:
> On Mon, Jun 01, 2015 at 12:43:35PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 01/06/2015 12:23, Michael S. Tsirkin wrote:
>>> Still, reserving part of the namespace for QEMU internal use
>>> is *not* policy, it's just good engineering.
>>>
>>> How about we forbid adding files under "etc/" ?
>>>
>>> That would be enough to avoid conflicts.
>>
>> I do not understand. What we're doing is free-beer. We can always say
>> no. What's your worry?
>
> Someone writes a tool using a specific path.
> We then add same path upstream, script breaks.
Who cares. We documented it.
>> One usecase of this feature is to avoid recompiling QEMU while playing
>> with firmware. If you cannot mimic QEMU's behavior (which is to add
>> "etc/" files), the feature is pointless, or at least I totally cannot
>> understand its purpose and I'm against merging it.
>
> Confused. Why does it produce the warning then?
Because someone else asked for it. I cannot answer. :)
> If it's just for playing games, add a configure
> switch to enable it, and disable by default.
> Don't set traps for users.
What is for playing games? What is the feature useful for, except for
developers.
Paolo
next prev parent reply other threads:[~2015-06-01 10:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 15:21 [Qemu-devel] [PATCH V4 0/4] fw-cfg: cleanup and user-provided command line blobs Gabriel L. Somlo
2015-04-29 15:21 ` [Qemu-devel] [PATCH V4 1/4] fw_cfg: remove support for guest-side data writes Gabriel L. Somlo
2015-04-29 15:21 ` [Qemu-devel] [PATCH V4 2/4] fw_cfg: prevent selector key conflict Gabriel L. Somlo
2015-04-29 15:21 ` [Qemu-devel] [PATCH V4 3/4] fw_cfg: prohibit insertion of duplicate fw_cfg file names Gabriel L. Somlo
2015-04-29 15:21 ` [Qemu-devel] [PATCH V4 4/4] fw_cfg: insert fw_cfg file blobs via qemu cmdline Gabriel L. Somlo
2015-05-31 18:10 ` Michael S. Tsirkin
2015-06-01 7:06 ` Laszlo Ersek
2015-06-01 7:28 ` Michael S. Tsirkin
2015-06-01 9:01 ` Paolo Bonzini
2015-06-01 10:23 ` Michael S. Tsirkin
2015-06-01 10:35 ` Laszlo Ersek
2015-06-01 10:42 ` Michael S. Tsirkin
2015-06-01 11:19 ` Laszlo Ersek
2015-06-01 10:43 ` Paolo Bonzini
2015-06-01 10:48 ` Michael S. Tsirkin
2015-06-01 10:50 ` Paolo Bonzini [this message]
2015-06-01 11:00 ` Michael S. Tsirkin
2015-06-01 11:18 ` Paolo Bonzini
2015-06-01 11:05 ` Gabriel L. Somlo
2015-06-01 11:20 ` Markus Armbruster
2015-06-01 11:21 ` Paolo Bonzini
2015-06-01 11:26 ` Laszlo Ersek
2015-06-01 12:38 ` Michael S. Tsirkin
2015-06-01 12:39 ` Paolo Bonzini
2015-06-01 12:41 ` Michael S. Tsirkin
2015-06-01 12:43 ` Paolo Bonzini
2015-06-02 7:37 ` Gerd Hoffmann
2015-06-02 8:28 ` Michael S. Tsirkin
2015-06-02 9:43 ` Gerd Hoffmann
2015-06-01 13:21 ` Laszlo Ersek
2015-06-01 11:24 ` Laszlo Ersek
2015-05-18 13:05 ` [Qemu-devel] [PATCH V4 0/4] fw-cfg: cleanup and user-provided command line blobs Gabriel L. Somlo
2015-05-29 12:41 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C390A.7090706@redhat.com \
--to=pbonzini@redhat.com \
--cc=gsomlo@gmail.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=matt.fleming@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).