From: Paolo Bonzini <pbonzini@redhat.com>
To: Dmitry Monakhov <dmonakhov@openvz.org>,
"Denis V. Lunev" <den@odin.com>,
Stefan Hajnoczi <stefanha@gmail.com>
Cc: Dmitry Monakhov <dmonakhov@odin.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign
Date: Mon, 01 Jun 2015 13:26:28 +0200 [thread overview]
Message-ID: <556C4164.6040906@redhat.com> (raw)
In-Reply-To: <87382b8yr3.fsf@openvz.org>
On 01/06/2015 13:16, Dmitry Monakhov wrote:
> 259,0 31 385 0.719283423 10729 Q WS 29376775 + 248 [qemu-io]
> 259,0 31 388 0.719287600 10729 Q WS 29377023 + 8 [qemu-io]
> 259,0 31 391 0.719315193 10729 Q WS 29377031 + 248 [qemu-io]
> 259,0 31 394 0.719319179 10729 Q WS 29377279 + 8 [qemu-io]
Compared to the old one:
> 9,0 11 1 0.000000000 11151 Q WS 312737792 + 1023 [qemu-img]
> 9,0 11 2 0.000007938 11151 Q WS 312738815 + 8 [qemu-img]
> 9,0 11 3 0.000030735 11151 Q WS 312738823 + 1016 [qemu-img]
> 9,0 11 4 0.000032482 11151 Q WS 312739839 + 8 [qemu-img]
> 9,0 11 5 0.000041379 11151 Q WS 312739847 + 1016 [qemu-img]
> 9,0 11 6 0.000042818 11151 Q WS 312740863 + 8 [qemu-img]
> 9,0 11 7 0.000051236 11151 Q WS 312740871 + 1017 [qemu-img]
I suspect the difference is that my patch avoids RMW operations on disks
that have 512-byte logical blocks and 4K physical blocks.
Paolo
next prev parent reply other threads:[~2015-06-01 11:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 13:42 [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-05-04 13:42 ` [Qemu-devel] [PATCH 1/2] block: minimal bounce buffer alignment Denis V. Lunev
2015-05-04 13:42 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-05-11 14:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-11 15:32 ` Eric Blake
2015-05-11 15:40 ` Denis V. Lunev
2015-05-11 15:08 ` [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Stefan Hajnoczi
2015-05-11 16:07 ` Denis V. Lunev
2015-05-11 16:38 ` Denis V. Lunev
2015-05-11 16:47 ` Denis V. Lunev
2015-05-12 10:01 ` Stefan Hajnoczi
2015-05-12 10:19 ` Denis V. Lunev
2015-05-12 10:46 ` Paolo Bonzini
2015-05-13 15:43 ` Stefan Hajnoczi
2015-05-13 16:46 ` Denis V. Lunev
2015-05-29 16:43 ` [Qemu-devel] " Paolo Bonzini
2015-06-01 10:34 ` Dmitry Monakhov
2015-06-01 10:41 ` Paolo Bonzini
2015-06-01 11:16 ` Dmitry Monakhov
2015-06-01 11:26 ` Paolo Bonzini [this message]
2015-06-01 11:57 ` Dmitry Monakhov
2015-05-14 9:13 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556C4164.6040906@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@odin.com \
--cc=dmonakhov@odin.com \
--cc=dmonakhov@openvz.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).