From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzQy0-0006XF-96 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:45:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzQxv-0005V5-24 for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:45:28 -0400 Received: from mail-wi0-x22a.google.com ([2a00:1450:400c:c05::22a]:37643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzQxu-0005Uw-Qa for qemu-devel@nongnu.org; Mon, 01 Jun 2015 10:45:22 -0400 Received: by wifw1 with SMTP id w1so108383293wif.0 for ; Mon, 01 Jun 2015 07:45:22 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <556C6FFE.6000803@redhat.com> Date: Mon, 01 Jun 2015 16:45:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1433167752-5311-1-git-send-email-marcel@redhat.com> <556C686C.3090407@redhat.com> In-Reply-To: <556C686C.3090407@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/q35: fix floppy controller definition in ich9 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: jsnow@redhat.com, kraxel@redhat.com, mst@redhat.com On 01/06/2015 16:13, Marcel Apfelbaum wrote: > >> In DSDT FDC0 declares the IO region as IO(Decode16, 0x03F2, 0x03F2, >> 0x00, 0x04). >> Use the same in lpc_ich9 initialization code. >> Now the floppy drive is detected correctly on Windows. >> >> Signed-off-by: Marcel Apfelbaum >> --- >> hw/isa/lpc_ich9.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c >> index dba7585..bc9afc6 100644 >> --- a/hw/isa/lpc_ich9.c >> +++ b/hw/isa/lpc_ich9.c >> @@ -494,7 +494,7 @@ static void ich9_lpc_machine_ready(Notifier *n, >> void *opaque) >> /* lpt */ >> pci_conf[0x82] |= 0x04; >> } >> - if (memory_region_present(io_as, 0x3f0)) { >> + if (memory_region_present(io_as, 0x3f2)) { >> /* floppy */ >> pci_conf[0x82] |= 0x08; >> } >> > > Hi, > > I cc-ed the developers involved in the mail thread: > https://lists.gnu.org/archive/html/qemu-block/2015-05/msg01043.html > and the FDC maintainer. I hope I didn't miss anybody. > > I also have no knowledge of FDC, but I think the above patch is correct > and solves the problem of floppy disk missing in Windows for Q35 machines. The patch is okay, but the correct definition of the area is from 0x3F1 to 0x3F7. Paolo